Bug 1576826 - Intermittent Assertion failure: isResponse, at NetlinkService.cpp:613, r=kershaw
authorMichal Novotny <michal.novotny@gmail.com>
Thu, 29 Aug 2019 12:08:53 +0000
changeset 551108 ad671f671ffaed65ca06c3376e3ea0257497a6f9
parent 551107 8edbf8fe48bfd2daeff36e5a6716e5d8c6cc3f69
child 551109 3252b137dadf651c1a259f71b3a20ab1edd9f0be
push id11865
push userbtara@mozilla.com
push dateMon, 02 Sep 2019 08:54:37 +0000
treeherdermozilla-beta@37f59c4671b3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskershaw
bugs1576826
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1576826 - Intermittent Assertion failure: isResponse, at NetlinkService.cpp:613, r=kershaw Obviously broadcasted messages can be multipart too. Differential Revision: https://phabricator.services.mozilla.com/D43849
netwerk/system/netlink/NetlinkService.cpp
--- a/netwerk/system/netlink/NetlinkService.cpp
+++ b/netwerk/system/netlink/NetlinkService.cpp
@@ -604,18 +604,16 @@ void NetlinkService::OnNetlinkMessage(in
         RemovePendingMsg();
         continue;
       }
     }
 
     switch (nlh->nlmsg_type) {
       case NLMSG_DONE: /* Message signalling end of dump for responses to
                           request containing NLM_F_DUMP flag */
-        MOZ_ASSERT(
-            isResponse);  // Could broadcasted message be reply to NLM_F_DUMP?
         if (isResponse) {
           RemovePendingMsg();
         }
         break;
       case NLMSG_ERROR:
         if (isResponse) {
           if (mOutgoingMessages[0]->MsgType() == NetlinkMsg::kRtMsg) {
             OnRouteCheckResult(nullptr);