HeadersPanel: unecessary isRequired on PropTypes (Bug 1530323) r=Honza
authorlucas <lucasneiva07@gmail.com>
Tue, 05 Mar 2019 14:55:42 +0000
changeset 520263 ad6491a3248159b88e915c13de7e70af8babd568
parent 520262 2ee118b40f31cc0b201e26a32135581b33329697
child 520264 ae274634278fa08c629d11b98d1c14bf2baf70ee
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersHonza
bugs1530323
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
HeadersPanel: unecessary isRequired on PropTypes (Bug 1530323) r=Honza Before this change, member was considered a required Prop on the file HeadersPanel.js. The component itself wasn't using this prop, it was only passing to the renderValue as a prop, and then renderValue uses member to render the data. So, the simpler solution is remove isRequired from the PropTypes. Differential Revision: https://phabricator.services.mozilla.com/D21539
devtools/client/netmonitor/src/components/HeadersPanel.js
--- a/devtools/client/netmonitor/src/components/HeadersPanel.js
+++ b/devtools/client/netmonitor/src/components/HeadersPanel.js
@@ -64,17 +64,17 @@ const SUMMARY_REFERRER_POLICY = L10N.get
  * Headers panel component
  * Lists basic information about the request
  */
 class HeadersPanel extends Component {
   static get propTypes() {
     return {
       connector: PropTypes.object.isRequired,
       cloneSelectedRequest: PropTypes.func.isRequired,
-      member: PropTypes.object.isRequired,
+      member: PropTypes.object,
       request: PropTypes.object.isRequired,
       renderValue: PropTypes.func,
       openLink: PropTypes.func,
     };
   }
 
   constructor(props) {
     super(props);