Replace float by CGFloat to fix BoxShadows on 64-bit OS X + added reftest. b=562616 r=jmuizelaar
authorBenoit Girard <b56girard@gmail.com>
Wed, 09 Jun 2010 00:11:38 -0400
changeset 43367 ad21f6e7d15ad8e441e31d4bb22c1038c9c00d9c
parent 43366 6c1ece4396420749451754ef3caf32d45c18003f
child 43368 014ea2ea49981560a00b769205f4921c164260f8
push id1
push userroot
push dateTue, 26 Apr 2011 22:38:44 +0000
treeherdermozilla-beta@bfdb6e623a36 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmuizelaar
bugs562616
milestone1.9.3a5pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Replace float by CGFloat to fix BoxShadows on 64-bit OS X + added reftest. b=562616 r=jmuizelaar
gfx/cairo/cairo/src/cairo-quartz-surface.c
layout/reftests/box-shadow/boxshadow-blur-notref2.html
layout/reftests/box-shadow/reftest.list
--- a/gfx/cairo/cairo/src/cairo-quartz-surface.c
+++ b/gfx/cairo/cairo/src/cairo-quartz-surface.c
@@ -229,17 +229,17 @@ CGImageRef
     if (!dataProvider) {
 	// manually release
 	if (releaseCallback)
 	    releaseCallback (releaseInfo, data, height * stride);
 	goto FINISH;
     }
 
     if (format == CAIRO_FORMAT_A8 || format == CAIRO_FORMAT_A1) {
-	float decode[] = {1.0, 0.0};
+	CGFloat decode[] = {1.0, 0.0};
 	image = CGImageMaskCreate (width, height,
 				   bitsPerComponent,
 				   bitsPerPixel,
 				   stride,
 				   dataProvider,
 				   decode,
 				   interpolate);
     } else
new file mode 100644
--- /dev/null
+++ b/layout/reftests/box-shadow/boxshadow-blur-notref2.html
@@ -0,0 +1,16 @@
+<!DOCTYPE HTML>
+<style>
+body {
+  background-color: green;
+}
+
+#thediv {
+  width: 300px;
+  height: 100px;
+  position: absolute;
+  top: 20px;
+  left: 20px;
+}
+</style>
+
+<div id="thediv">Foo</div> 
--- a/layout/reftests/box-shadow/reftest.list
+++ b/layout/reftests/box-shadow/reftest.list
@@ -1,10 +1,11 @@
 == boxshadow-basic.html boxshadow-basic-ref.html
 != boxshadow-blur.html boxshadow-blur-notref.html
+!= boxshadow-blur.html boxshadow-blur-notref2.html
 == boxshadow-multiple.html boxshadow-multiple-ref.html
 == boxshadow-spread.html boxshadow-spread-ref.html
 == tableboxshadow-basic.html tableboxshadow-basic-ref.html
 == tableboxshadow-trshadow.html tableboxshadow-trshadow-ref.html
 == tableboxshadow-tdshadow.html tableboxshadow-tdshadow-ref.html
 == boxshadow-rounding.html boxshadow-rounding-ref.html
 == boxshadow-button.html boxshadow-button-ref.html
 == boxshadow-fileupload.html boxshadow-fileupload-ref.html