Bug 1549667 - [mips] skip tests which need --spectre-XXX on.
☠☠ backed out by d4a9de6a57b7 ☠ ☠
authorYu Yin <yuyin-hf@loongson.cn>
Fri, 10 May 2019 09:42:38 +0300
changeset 532168 acf19aefc4d23947c202b2eaf445b7ef332d7777
parent 532167 5d580fa5d7531f846acac842f7c9eec92a52a460
child 532169 b0a2912f83a9bc268e8f1f0185608d1ccee22b55
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1549667
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1549667 - [mips] skip tests which need --spectre-XXX on. Reviewers: jandem, lth Reviewed By: jandem Subscribers: jandem Bug #: 1549667 Differential Revision: https://phabricator.services.mozilla.com/D30172
js/src/builtin/TestingFunctions.cpp
js/src/jit-test/tests/ion/bug1433496.js
--- a/js/src/builtin/TestingFunctions.cpp
+++ b/js/src/builtin/TestingFunctions.cpp
@@ -250,16 +250,34 @@ static bool GetBuildConfiguration(JSCont
   value = BooleanValue(true);
 #else
   value = BooleanValue(false);
 #endif
   if (!JS_SetProperty(cx, info, "arm64-simulator", value)) {
     return false;
   }
 
+#ifdef JS_CODEGEN_MIPS32
+  value = BooleanValue(true);
+#else
+  value = BooleanValue(false);
+#endif
+  if (!JS_SetProperty(cx, info, "mips32", value)) {
+    return false;
+  }
+
+#ifdef JS_CODEGEN_MIPS64
+  value = BooleanValue(true);
+#else
+  value = BooleanValue(false);
+#endif
+  if (!JS_SetProperty(cx, info, "mips64", value)) {
+    return false;
+  }
+
 #ifdef JS_SIMULATOR_MIPS32
   value = BooleanValue(true);
 #else
   value = BooleanValue(false);
 #endif
   if (!JS_SetProperty(cx, info, "mips32-simulator", value)) {
     return false;
   }
--- a/js/src/jit-test/tests/ion/bug1433496.js
+++ b/js/src/jit-test/tests/ion/bug1433496.js
@@ -1,6 +1,6 @@
-// |jit-test| --spectre-mitigations=on
+// |jit-test| --spectre-mitigations=on; skip-if: getBuildConfiguration()['mips32'] || getBuildConfiguration()['mips64']
 function f() {
     return arguments[arguments.length];
 }
 for (var i = 0; i < 10; i++)
     assertEq(f(), undefined);