Bug 1495582 [wpt PR 13296] - ConvolverNode buffer can be set multiple times, a=testonly
authorRaymond Toy <rtoy@chromium.org>
Tue, 09 Oct 2018 04:12:15 +0000
changeset 495906 ac3bae0271164e6af9c57dbba1a60c26ae6e6ff2
parent 495905 19e5f6bbde58da50a0bcd98d9d0a161f3855c630
child 495907 68fb71895c38ca823f7ec31bced1545fb7012e8d
push id9984
push userffxbld-merge
push dateMon, 15 Oct 2018 21:07:35 +0000
treeherdermozilla-beta@183d27ea8570 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1495582, 13296, 1077713, 882211, 1249275, 595586
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1495582 [wpt PR 13296] - ConvolverNode buffer can be set multiple times, a=testonly Automatic update from web-platform-testsConvolverNode buffer can be set multiple times It is valid to set the buffer attribute more than once. As resolved in https://github.com/WebAudio/web-audio-api/issues/1762, setting the buffer more than once is allowed. This is a revert (mostly) of https://chromium-review.googlesource.com/c/chromium/src/+/1077713 Bug: 882211 Test: the-convolvernode-interface/convolver-setBuffer-already-has-value.html Change-Id: Ie7f170883e6a6b2bfa7f14d89c74b72eebde3dac Reviewed-on: https://chromium-review.googlesource.com/1249275 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595586} -- wpt-commits: 67152fdecd6e7955f934a4aec9a15407cbcfa3ac wpt-pr: 13296
testing/web-platform/tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-setBuffer-already-has-value.html
--- a/testing/web-platform/tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-setBuffer-already-has-value.html
+++ b/testing/web-platform/tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-setBuffer-already-has-value.html
@@ -22,30 +22,30 @@
         }, 'Set buffer to null before set non-null').notThrow();
 
         should(() => {
           convolver.buffer = audioBuffer;
         }, 'Set buffer first normally').notThrow();
 
         should(() => {
           convolver.buffer = audioBuffer;
-        }, 'Set buffer a second time').throw(DOMException, 'InvalidStateError');
+        }, 'Set buffer a second time').notThrow();
 
         should(() => {
           convolver.buffer = null;
         }, 'Set buffer to null').notThrow();
 
         should(() => {
           convolver.buffer = null;
         }, 'Set buffer to null again, to make sure').notThrow();
 
         should(() => {
           convolver.buffer = audioBuffer;
-        }, 'Set buffer to non-null to verify to throw an error')
-        .throw(DOMException, 'InvalidStateError');
+        }, 'Set buffer to non-null to verify it is set')
+        .notThrow();
 
         task.done();
       });
 
       audit.run();
     </script>
   </body>
 </html>