Bug 863106 - Check for minidumps directory only when crash reporter is enabled. r=jmaher
authorNick Alexander <nalexander@mozilla.com>
Fri, 19 Apr 2013 15:31:16 -0700
changeset 140335 ac14e49337b84ae56dcee9206e3b2b26f922faee
parent 140334 c1483e6de03a07c86cb807fb9cbc1cbfacf4c317
child 140336 f9405d359a22f98b952f2d0bf4d19d27f30df10e
push id2579
push userakeybl@mozilla.com
push dateMon, 24 Jun 2013 18:52:47 +0000
treeherdermozilla-beta@b69b7de8a05a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher
bugs863106
milestone23.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 863106 - Check for minidumps directory only when crash reporter is enabled. r=jmaher
build/mobile/remoteautomation.py
--- a/build/mobile/remoteautomation.py
+++ b/build/mobile/remoteautomation.py
@@ -116,23 +116,30 @@ class RemoteAutomation(Automation):
                 break
         return found_exception
 
     def checkForCrashes(self, directory, symbolsPath):
         logcat = self._devicemanager.getLogcat(filterOutRegexps=fennecLogcatFilters)
         javaException = self.checkForJavaException(logcat)
         if javaException:
             return True
+
+        # If crash reporting is disabled (MOZ_CRASHREPORTER!=1), we can't say
+        # anything.
+        if not self.CRASHREPORTER:
+            return False
+
         try:
             dumpDir = tempfile.mkdtemp()
             remoteCrashDir = self._remoteProfile + '/minidumps/'
             if not self._devicemanager.dirExists(remoteCrashDir):
-                # As of this writing, the minidumps directory is automatically
-                # created when fennec (first) starts, so its lack of presence
-                # is a hint that something went wrong.
+                # If crash reporting is enabled (MOZ_CRASHREPORTER=1), the
+                # minidumps directory is automatically created when Fennec
+                # (first) starts, so its lack of presence is a hint that
+                # something went wrong.
                 print "Automation Error: No crash directory (%s) found on remote device" % remoteCrashDir
                 # Whilst no crash was found, the run should still display as a failure
                 return True
             self._devicemanager.getDirectory(remoteCrashDir, dumpDir)
             crashed = Automation.checkForCrashes(self, dumpDir, symbolsPath)
 
         finally:
             try: