Bug 557532 - controls pane exit button flips position when coming back from orientation change [r=vingtetun]
authorMark Finkle <mfinkle@mozilla.com>
Tue, 06 Apr 2010 13:05:54 -0400
changeset 66107 abcf3d4f2c633c3680d14a9796f8187754d6e864
parent 66106 969f9b1d8b1d0d279d736748de32f7e5cc650218
child 66108 aee7068d55fcee2b0d97465a30c09e0bb0c7c496
push id1
push userroot
push dateTue, 26 Apr 2011 22:38:44 +0000
treeherdermozilla-beta@bfdb6e623a36 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersvingtetun
bugs557532
Bug 557532 - controls pane exit button flips position when coming back from orientation change [r=vingtetun]
mobile/chrome/content/browser.xul
mobile/themes/hildon/browser.css
mobile/themes/wince/browser.css
--- a/mobile/chrome/content/browser.xul
+++ b/mobile/chrome/content/browser.xul
@@ -334,21 +334,21 @@
       </hbox>
       <hbox pack="center">
         <button class="button-dark" label="&editBookmarkDone.label;" oncommand="BookmarkHelper.save();"/>
       </hbox>
     </vbox>
 
     <box id="panel-container" class="panel-dark window-width window-height" style="-moz-stack-sizing: ignore" left="10000" hidden="true">
       <box id="panel-controls" oncommand="BrowserUI.switchPane(event.target.getAttribute('linkedpanel'));">
-        <toolbarbutton id="tool-panel-close" class="page-button button-image" command="cmd_panel"/>
         <toolbarbutton id="tool-addons" type="radio" group="1" class="panel-button button-image" linkedpanel="addons-container"/>
         <toolbarbutton id="tool-downloads" type="radio" group="1" class="panel-button button-image" linkedpanel="downloads-container"/>
         <toolbarbutton id="tool-preferences" type="radio" group="1" checked="true" class="panel-button button-image" linkedpanel="prefs-container"/>
         <toolbarbutton id="tool-console" type="radio" group="1" hidden="true" class="panel-button button-image" linkedpanel="console-container"/>
+        <toolbarbutton id="tool-panel-close" class="page-button button-image" command="cmd_panel"/>
       </box>
       <deck id="panel-items" selectedIndex="2" flex="1">
         <vbox id="addons-container" flex="1">
           <hbox id="addons-header" class="panel-header">
             <label value="&addonsHeader.label;"/>
           </hbox>
           <notificationbox id="addons-messages" flex="1">
             <richlistbox id="addons-list" flex="1" onselect="ExtensionsView.hideOnSelect(event)">
--- a/mobile/themes/hildon/browser.css
+++ b/mobile/themes/hildon/browser.css
@@ -278,51 +278,47 @@ toolbarbutton.page-button {
 @media (min-width: 500px) {
   #panel-container {
     -moz-box-orient: horizontal;
     -moz-box-direction: normal;
   }
 
   #panel-controls {
     -moz-box-orient: vertical;
-    -moz-box-pack: end;
-  }
-
-  #tool-panel-close {
-    -moz-box-ordinal-group: 1000;
+    -moz-box-direction: normal;
   }
 }
 
 @media (max-width: 499px) {
   #panel-container {
     -moz-box-orient: vertical;
     -moz-box-direction: reverse;
   }
 
   #panel-controls {
     -moz-box-orient: horizontal;
-    -moz-box-pack: start;
+    -moz-box-direction: reverse;
     padding-top: 8px; /* core spacing */
   }
 
   #tool-panel-close {
-    -moz-box-ordinal-group: 1;
     margin-right: 8px; /* core spacing */
   }
 
   toolbarbutton.panel-button {
     margin-right: 8px; /* core spacing */
   }
 }
 
 #panel-controls {
   /* match #browser-controls end padding */
   padding-left: 8px; /* core spacing */
   padding-right: 8px; /* core spacing */
   -moz-box-align: end;
+  -moz-box-pack: end;
 }
 
 .panel-header {
   padding: 8px; /* core spacing */
 }
 
 #tool-addons {
   list-style-image: url("chrome://browser/skin/images/addons-default-64.png");
--- a/mobile/themes/wince/browser.css
+++ b/mobile/themes/wince/browser.css
@@ -122,51 +122,47 @@ toolbarbutton.page-button {
 @media (min-width: 500px) {
   #panel-container {
     -moz-box-orient: horizontal;
     -moz-box-direction: normal;
   }
 
   #panel-controls {
     -moz-box-orient: vertical;
-    -moz-box-pack: end;
-  }
-
-  #tool-panel-close {
-    -moz-box-ordinal-group: 1000;
+    -moz-box-direction: normal;
   }
 }
 
 @media (max-width: 500px) {
   #panel-container {
     -moz-box-orient: vertical;
     -moz-box-direction: reverse;
   }
 
   #panel-controls {
     -moz-box-orient: horizontal;
-    -moz-box-pack: start;
+    -moz-box-direction: reverse;
     padding-top: 1.1mm; /* core spacing */
   }
 
   #tool-panel-close {
-    -moz-box-ordinal-group: 1;
     margin-right: 1.1mm; /* core spacing */
   }
 
   toolbarbutton.panel-button {
     margin-right: 1.1mm; /* core spacing */
   }
 }
 
 #panel-controls {
   /* match #browser-controls end padding */
   padding-left: 1.1mm; /* core spacing */
   padding-right: 1.1mm; /* core spacing */
   -moz-box-align: end;
+  -moz-box-pack: end;
 }
 
 .panel-header {
   padding: 1.1mm; /* core spacing */
 }
 
 /* addons panel UI   ------------------------------------------------------- */
 @media (min-width: 500px) {