Bug 931445 - Part 5 - Avoid childIframe subtest to be started twice. r=smaug, a=test-only
authorXidorn Quan <me@upsuper.org>
Wed, 03 Aug 2016 15:14:49 +1000
changeset 348125 ab5dbae4c8e22ad92ce1bffbf0198396aeb4ccfc
parent 348124 79429ecdadfa79a101cff2add3d5c1eac5b07e7f
child 348126 dd74105957e26e3134fd6306473d7303cd6b0165
push id6389
push userraliiev@mozilla.com
push dateMon, 19 Sep 2016 13:38:22 +0000
treeherdermozilla-beta@01d67bfe6c81 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug, test-only
bugs931445
milestone50.0a2
Bug 931445 - Part 5 - Avoid childIframe subtest to be started twice. r=smaug, a=test-only This is a silly bug that start() is called twice in this subtest, one from the load event of the document (by pointerlock_utils.js), the other is by onload of the iframe. Given the document's load event comes later, I removed the onload of iframe. MozReview-Commit-ID: 7TQJVa3xCb9
dom/tests/mochitest/pointerlock/file_childIframe.html
dom/tests/mochitest/pointerlock/mochitest.ini
--- a/dom/tests/mochitest/pointerlock/file_childIframe.html
+++ b/dom/tests/mochitest/pointerlock/file_childIframe.html
@@ -32,17 +32,17 @@ https://bugzilla.mozilla.org/show_bug.cg
   <a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=633602">
     Mozilla Bug 633602
   </a>
 
   <div id="parent">
     <table id="childTable">
       <tr>
         <td>
-          <iframe id="iframe" src="iframe_differentDOM.html" onload="start();">
+          <iframe id="iframe" src="iframe_differentDOM.html">
           </iframe>
         </td>
         <td>
           <div id="childDiv">
           </div>
         </td>
       </tr>
     </table>
--- a/dom/tests/mochitest/pointerlock/mochitest.ini
+++ b/dom/tests/mochitest/pointerlock/mochitest.ini
@@ -18,9 +18,9 @@ support-files =
   file_suppressSomeMouseEvents.html
   file_locksvgelement.html
   file_allowPointerLockSandboxFlag.html
   file_changeLockElement.html
   iframe_differentDOM.html
 
 [test_pointerlock-api.html]
 tags = fullscreen
-skip-if = buildapp == 'b2g' || toolkit == 'android' || os == 'win' # B2G - window.open focus issues using fullscreen. Win: Bug 931445
+skip-if = buildapp == 'b2g' || toolkit == 'android' # B2G - window.open focus issues using fullscreen.