Bug 1518834 - Don't disable pulling when stopping microphone source. r=drno, a=RyanVM
authorAndreas Pehrson <apehrson@mozilla.com>
Thu, 10 Jan 2019 06:13:25 +0000
changeset 506619 aaeaf42a092dd7c12c17e6a5850aa9d93129477f
parent 506618 c4bda79261ba60e22768197f8219d7061e066227
child 506620 e620bf5160a4685b2728d28d2bf0eaa1dbf9d786
push id10483
push userryanvm@gmail.com
push dateThu, 10 Jan 2019 18:48:52 +0000
treeherdermozilla-beta@e620bf5160a4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdrno, RyanVM
bugs1518834
milestone65.0
Bug 1518834 - Don't disable pulling when stopping microphone source. r=drno, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D16148
dom/media/webrtc/MediaEngineWebRTCAudio.cpp
--- a/dom/media/webrtc/MediaEngineWebRTCAudio.cpp
+++ b/dom/media/webrtc/MediaEngineWebRTCAudio.cpp
@@ -607,22 +607,21 @@ nsresult MediaEngineWebRTCMicrophoneSour
 
   if (mState == kStopped) {
     // Already stopped - this is allowed
     return NS_OK;
   }
 
   RefPtr<MediaEngineWebRTCMicrophoneSource> that = this;
   NS_DispatchToMainThread(
-      media::NewRunnableFrom([that, stream = mStream, track = mTrackID]() {
+      media::NewRunnableFrom([that, stream = mStream]() {
         if (stream->IsDestroyed()) {
           return NS_OK;
         }
 
-        stream->SetPullingEnabled(track, false);
         stream->GraphImpl()->AppendMessage(MakeUnique<StartStopMessage>(
             that->mInputProcessing, StartStopMessage::Stop));
         CubebUtils::AudioDeviceID deviceID = that->mDeviceInfo->DeviceID();
         Maybe<CubebUtils::AudioDeviceID> id = Some(deviceID);
         stream->CloseAudioInput(id, that->mInputProcessing);
 
         return NS_OK;
       }));