Bug 1276184: [MSE] P1. Scan where to start removing frames from the start if new block added starts with a keyframe. r=kamidphish, a=gchang
authorJean-Yves Avenard <jyavenard@mozilla.com>
Thu, 02 Jun 2016 16:40:43 +1000
changeset 333545 aa702c6e60ea
parent 333544 ebaf4086c18c
child 333546 3c50c8027389
push id6161
push usercbook@mozilla.com
push dateMon, 04 Jul 2016 13:50:39 +0000
treeherdermozilla-beta@3e04c4853a8b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskamidphish, gchang
bugs1276184
milestone48.0
Bug 1276184: [MSE] P1. Scan where to start removing frames from the start if new block added starts with a keyframe. r=kamidphish, a=gchang We keep the next position on where to add frames so that we do not break the current coded frame group. However, when the new group of added frames starts with a keyframe we do not have to worry about breaking the previous coded frame group. MozReview-Commit-ID: G81xGuSa4Y2
dom/media/mediasource/TrackBuffersManager.cpp
--- a/dom/media/mediasource/TrackBuffersManager.cpp
+++ b/dom/media/mediasource/TrackBuffersManager.cpp
@@ -1622,16 +1622,22 @@ TrackBuffersManager::InsertFrames(TrackB
 
   // 15. Remove decoding dependencies of the coded frames removed in the previous step:
   // Remove all coded frames between the coded frames removed in the previous step and the next random access point after those removed frames.
 
   TimeIntervals intersection = trackBuffer.mBufferedRanges;
   intersection.Intersection(aIntervals);
 
   if (intersection.Length()) {
+    if (aSamples[0]->mKeyframe) {
+      // We are starting a new GOP, we do not have to worry about breaking an
+      // existing current coded frame group. Reset the next insertion index
+      // so the search for when to start our frames removal can be exhaustive.
+      trackBuffer.mNextInsertionIndex.reset();
+    }
     RemoveFrames(aIntervals, trackBuffer, trackBuffer.mNextInsertionIndex.refOr(0));
   }
 
   // 16. Add the coded frame with the presentation timestamp, decode timestamp, and frame duration to the track buffer.
   if (!CheckNextInsertionIndex(aTrackData,
                                TimeUnit::FromMicroseconds(aSamples[0]->mTime))) {
     RejectProcessing(NS_ERROR_FAILURE, __func__);
     return;