Bug 1253395 - Disable msmpeg2vdec.dll blackslisting - r=cpearce a=ritu
authorGerald Squelart <gsquelart@mozilla.com>
Tue, 08 Mar 2016 12:54:48 +1100
changeset 323427 aa6c02ad1e3a93d81846685911b12fe2de7a6da8
parent 323426 c3bcee5d608ccc8c95e01b7eeef49e869f928966
child 323428 a581625cd4888fc1cfbfebaffec9a8a9c144998e
push id5913
push userjlund@mozilla.com
push dateMon, 25 Apr 2016 16:57:49 +0000
treeherdermozilla-beta@dcaf0a6fa115 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscpearce, ritu
bugs1253395, 1242343
milestone47.0a2
Bug 1253395 - Disable msmpeg2vdec.dll blackslisting - r=cpearce a=ritu Disable the blacklisting introduced in bug 1242343, as it was having a negative effect on many working configurations. MozReview-Commit-ID: HRpmus7mtbz
dom/media/platforms/wmf/WMFDecoderModule.cpp
--- a/dom/media/platforms/wmf/WMFDecoderModule.cpp
+++ b/dom/media/platforms/wmf/WMFDecoderModule.cpp
@@ -162,17 +162,17 @@ CanCreateWMFDecoder()
     result.emplace(CanCreateMFTDecoder(aGuid));
   }
   return result.value();
 }
 
 static bool
 IsH264DecoderBlacklisted()
 {
-#ifdef _WIN64
+#ifdef BLACKLIST_CRASHY_H264_DECODERS
   WCHAR systemPath[MAX_PATH + 1];
   if (!ConstructSystem32Path(L"msmpeg2vdec.dll", systemPath, MAX_PATH + 1)) {
     // Cannot build path -> Assume it's not the blacklisted DLL.
     return false;
   }
 
   DWORD zero;
   DWORD infoSize = GetFileVersionInfoSizeW(systemPath, &zero);
@@ -188,17 +188,17 @@ IsH264DecoderBlacklisted()
   {
     if ((vInfo->dwFileVersionMS == ((12u << 16) | 0u))
         && ((vInfo->dwFileVersionLS == ((9200u << 16) | 16426u))
             || (vInfo->dwFileVersionLS == ((9200u << 16) | 17037u)))) {
       // 12.0.9200.16426 & .17037 are blacklisted on Win64, see bug 1242343.
       return true;
     }
   }
-#endif // _WIN64
+#endif // BLACKLIST_CRASHY_H264_DECODERS
   return false;
 }
 
 /* static */ bool
 WMFDecoderModule::HasH264()
 {
   if (IsH264DecoderBlacklisted()) {
     return false;