Bug 1496128 - Fix perma fail in browser/components/newtab/test/browser for search shortcuts r=k88hudson
authorUrsula Sarracini <ursulasarracini@gmail.com>
Thu, 04 Oct 2018 15:10:58 +0000
changeset 495362 a9d0b65595c1cfd92c7e78747244066e6bbf4d47
parent 495361 b3f8a012748697cb06502d7965a6950b010ac5f5
child 495363 53950ea4b1055b291c417948cc685f044fef97aa
push id9984
push userffxbld-merge
push dateMon, 15 Oct 2018 21:07:35 +0000
treeherdermozilla-beta@183d27ea8570 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersk88hudson
bugs1496128
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1496128 - Fix perma fail in browser/components/newtab/test/browser for search shortcuts r=k88hudson Each of the tests account for search shortcuts being there, so turning them off was leading to failures. Instead, we'll leave them on, since that will be the default case, and let the tests decide on the behaviour for themselves. Differential Revision: https://phabricator.services.mozilla.com/D7731
browser/components/newtab/test/browser/head.js
--- a/browser/components/newtab/test/browser/head.js
+++ b/browser/components/newtab/test/browser/head.js
@@ -14,16 +14,17 @@ function pushPrefs(...prefs) {
 
 async function setDefaultTopSites() { // eslint-disable-line no-unused-vars
   // The pref for TopSites is empty by default.
   await pushPrefs(["browser.newtabpage.activity-stream.default.sites",
     "https://www.youtube.com/,https://www.facebook.com/,https://www.amazon.com/,https://www.reddit.com/,https://www.wikipedia.org/,https://twitter.com/"]);
   // Toggle the feed off and on as a workaround to read the new prefs.
   await pushPrefs(["browser.newtabpage.activity-stream.feeds.topsites", false]);
   await pushPrefs(["browser.newtabpage.activity-stream.feeds.topsites", true]);
+  await pushPrefs(["browser.newtabpage.activity-stream.improvesearch.topSiteSearchShortcuts", true]);
 }
 
 async function clearHistoryAndBookmarks() { // eslint-disable-line no-unused-vars
   await PlacesUtils.bookmarks.eraseEverything();
   await PlacesUtils.history.clear();
   QueryCache.expireAll();
 }