Bug 813357 - Actually hand off our copy of the notification request to IPDL. r=gwagner
authorBlake Kaplan <mrbkap@gmail.com>
Mon, 19 Nov 2012 16:43:21 -0800
changeset 122834 a9014a296746dc59994dfa3a49b38a987d0b2d6b
parent 122833 d83f74d3768aa8f62c935833b5ea0520d64753b9
child 122835 899be7c28b2a2e5cbafe9f11ba3491b17363860d
push id2151
push userlsblakk@mozilla.com
push dateTue, 19 Feb 2013 18:06:57 +0000
treeherdermozilla-beta@4952e88741ec [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgwagner
bugs813357
milestone20.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 813357 - Actually hand off our copy of the notification request to IPDL. r=gwagner
dom/src/notification/nsDesktopNotification.cpp
--- a/dom/src/notification/nsDesktopNotification.cpp
+++ b/dom/src/notification/nsDesktopNotification.cpp
@@ -104,17 +104,17 @@ nsDOMDesktopNotification::Init()
     // because owner implements nsITabChild, we can assume that it is
     // the one and only TabChild for this docshell.
     TabChild* child = GetTabChildFrom(GetOwner()->GetDocShell());
 
     // Retain a reference so the object isn't deleted without IPDL's knowledge.
     // Corresponding release occurs in DeallocPContentPermissionRequest.
     nsRefPtr<nsDesktopNotificationRequest> copy = request;
 
-    child->SendPContentPermissionRequestConstructor(request,
+    child->SendPContentPermissionRequestConstructor(copy.forget().get(),
                                                     NS_LITERAL_CSTRING("desktop-notification"),
                                                     NS_LITERAL_CSTRING("unused"),
                                                     IPC::Principal(mPrincipal));
 
     request->Sendprompt();
     return;
   }