Bug 1321750 - Remove automatic color flags from HOST_CFLAGS, HOST_CXXFLAGS; r=glandium
authorGregory Szorc <gps@mozilla.com>
Fri, 02 Dec 2016 10:10:24 -0800
changeset 370114 a8e20bf36959426f0a6eb4b5df29ef3dd85ad4bd
parent 370113 f463014033520214bc213683fcb086ee3848cd30
child 370149 557548714db55136b51e1129d649e2599797985f
push id6996
push userjlorenzo@mozilla.com
push dateMon, 06 Mar 2017 20:48:21 +0000
treeherdermozilla-beta@d89512dab048 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1321750
milestone53.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1321750 - Remove automatic color flags from HOST_CFLAGS, HOST_CXXFLAGS; r=glandium moz.configure only sets the color flags value for the target compiler. If the host compiler is a different version and doesn't support color flags, we may pass unrecognized command line options. Until we have better distinction between host and target compilers throughout the build system, just disable automatic color flags for host invocations. We don't have too many host binaries, so this should have negligible impact. MozReview-Commit-ID: KWTLkKvtwHs
config/config.mk
--- a/config/config.mk
+++ b/config/config.mk
@@ -349,18 +349,16 @@ ifeq (,$(filter $(COLOR_CFLAGS:-f%=-fno-
 endif
 endef
 
 color_flags_vars := \
   COMPILE_CFLAGS \
   COMPILE_CXXFLAGS \
   COMPILE_CMFLAGS \
   COMPILE_CMMFLAGS \
-  HOST_CFLAGS \
-  HOST_CXXFLAGS \
   LDFLAGS \
   $(NULL)
 
 ifdef MACH_STDOUT_ISATTY
 ifdef COLOR_CFLAGS
 # TODO Bug 1319166 - iTerm2 interprets some bytes  sequences as a
 # request to show a print dialog. Don't enable color on iTerm2 until
 # a workaround is in place.