Bug 1546872 - Update cubeb from upstream to 64aa80f. r=padenot
authorAlex Chronopoulos <achronop@gmail.com>
Thu, 25 Apr 2019 20:14:32 +0300
changeset 530245 a885e5f28d3141921d9235adfdd0b88552e507a2
parent 530244 387aebeb7e8819e828f5c279db4d57dcdf42cf70
child 530246 159eaec1337ea82a0f4f7326849e6135327fda92
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspadenot
bugs1546872
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1546872 - Update cubeb from upstream to 64aa80f. r=padenot Pick commit: 64aa80f - wasapi: notify when a device is disabled. BMO 1546872
media/libcubeb/moz.yaml
media/libcubeb/src/cubeb_wasapi.cpp
--- a/media/libcubeb/moz.yaml
+++ b/media/libcubeb/moz.yaml
@@ -14,10 +14,10 @@ bugzilla:
 origin:
   name: "cubeb"
   description: "Cross platform audio library"
 
   url: "https://github.com/kinetiknz/cubeb"
   license: "ISC"
 
   # update.sh will update this value
-  release: "3570749942a4fea2b7e372833cb8374ce42cf389 (2019-04-24 13:04:01 +1200)"
+  release: "64aa80f330a3dc510b1e3ac0e92cc6bed129a9a6 (2019-04-25 17:32:33 +0200)"
 
--- a/media/libcubeb/src/cubeb_wasapi.cpp
+++ b/media/libcubeb/src/cubeb_wasapi.cpp
@@ -480,26 +480,22 @@ public:
   }
 
   HRESULT STDMETHODCALLTYPE
   OnDeviceStateChanged(LPCWSTR device_id, DWORD new_state)
   {
     XASSERT(cubeb_context->output_collection_changed_callback ||
             cubeb_context->input_collection_changed_callback);
     LOG("collection: Audio device state changed, id = %S, state = %lu.", device_id, new_state);
-    if (new_state == DEVICE_STATE_ACTIVE ||
-        new_state == DEVICE_STATE_NOTPRESENT ||
-        new_state == DEVICE_STATE_UNPLUGGED) {
-      EDataFlow flow;
-      HRESULT hr = GetDataFlow(device_id, &flow);
-      if (FAILED(hr)) {
-        return hr;
-      }
-      monitor_notifications.notify(flow);
+    EDataFlow flow;
+    HRESULT hr = GetDataFlow(device_id, &flow);
+    if (FAILED(hr)) {
+      return hr;
     }
+    monitor_notifications.notify(flow);
     return S_OK;
   }
 
   HRESULT STDMETHODCALLTYPE
   OnPropertyValueChanged(LPCWSTR device_id, const PROPERTYKEY key)
   {
     //Audio device property value changed.
     return S_OK;