Bug 711672 - Remove DEFINE_LOCAL_CLASS_OF_STATIC_FUNCTION as it's unused. r=luke
authorJeff Walden <jwalden@mit.edu>
Tue, 13 Dec 2011 14:26:57 -0500
changeset 84569 a8184aa6724190f6c9f0be7854b92072010c48c8
parent 84568 c4a0aafcf2d3573324cc805340ef4dc86a38278b
child 84570 0da67b6beb18b557b2327cea83b9d0311ea23cf4
push id519
push userakeybl@mozilla.com
push dateWed, 01 Feb 2012 00:38:35 +0000
treeherdermozilla-beta@788ea1ef610b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersluke
bugs711672
milestone11.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 711672 - Remove DEFINE_LOCAL_CLASS_OF_STATIC_FUNCTION as it's unused. r=luke
js/src/jstypes.h
--- a/js/src/jstypes.h
+++ b/js/src/jstypes.h
@@ -75,41 +75,28 @@
 **   in dowhim.h
 **     JS_EXTERN_API( void ) DoWhatIMean( void );
 **   in dowhim.c
 **     JS_EXPORT_API( void ) DoWhatIMean( void ) { return; }
 **
 **
 ***********************************************************************/
 
-#define DEFINE_LOCAL_CLASS_OF_STATIC_FUNCTION(Name) class Name
-
 #if defined(WIN32) || defined(XP_OS2)
 
 /* These also work for __MWERKS__ */
 # define JS_EXTERN_API(__type)  extern __declspec(dllexport) __type
 # define JS_EXPORT_API(__type)  __declspec(dllexport) __type
 # define JS_EXTERN_DATA(__type) extern __declspec(dllexport) __type
 # define JS_EXPORT_DATA(__type) __declspec(dllexport) __type
 
 #else /* Unix */
 
 # ifdef HAVE_VISIBILITY_ATTRIBUTE
 #  define JS_EXTERNAL_VIS __attribute__((visibility ("default")))
-#  if defined(__GNUC__) && __GNUC__ <= 4 && __GNUC_MINOR__ < 5
-    /*
-     * GCC wrongly produces a warning when a type with hidden visibility
-     * (e.g. js::Value) is a member of a local class of a static function.
-     * This is apparently fixed with GCC 4.5 and above.  See:
-     *
-     *   http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40145.
-     */
-#   undef  DEFINE_LOCAL_CLASS_OF_STATIC_FUNCTION
-#   define DEFINE_LOCAL_CLASS_OF_STATIC_FUNCTION(Name) class __attribute__((visibility ("hidden"))) Name
-#  endif
 # elif defined(__SUNPRO_C) || defined(__SUNPRO_CC)
 #  define JS_EXTERNAL_VIS __global
 # else
 #  define JS_EXTERNAL_VIS
 # endif
 
 # define JS_EXTERN_API(__type)  extern JS_EXTERNAL_VIS __type
 # define JS_EXPORT_API(__type)  JS_EXTERNAL_VIS __type