Bug 846774 - Make GeckoEvent member variables private. r=cpeterson a=bajaj
authorKartikaya Gupta <kgupta@mozilla.com>
Mon, 18 Mar 2013 23:00:05 +0100
changeset 132423 a7232156dacee23add5d37de37e3e91c6e71510b
parent 132422 bab7bc14c912b7d8455abfe5dc68420653a69caa
child 132424 a0e4c1622c7c9e1090f3e8c495c23ee6c5e047cd
push id2323
push userbbajaj@mozilla.com
push dateMon, 01 Apr 2013 19:47:02 +0000
treeherdermozilla-beta@7712be144d91 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscpeterson, bajaj
bugs846774
milestone21.0a2
Bug 846774 - Make GeckoEvent member variables private. r=cpeterson a=bajaj
mobile/android/base/GeckoEvent.java
--- a/mobile/android/base/GeckoEvent.java
+++ b/mobile/android/base/GeckoEvent.java
@@ -98,50 +98,60 @@ public class GeckoEvent {
     public static final int IME_RANGE_FORECOLOR = 2;
     public static final int IME_RANGE_BACKCOLOR = 4;
     public static final int IME_RANGE_LINECOLOR = 8;
 
     public static final int ACTION_MAGNIFY_START = 11;
     public static final int ACTION_MAGNIFY = 12;
     public static final int ACTION_MAGNIFY_END = 13;
 
-    final public int mType;
-    public int mAction;
-    public boolean mAckNeeded;
-    public long mTime;
-    public Point[] mPoints;
-    public int[] mPointIndicies;
-    public int mPointerIndex; // index of the point that has changed
-    public float[] mOrientations;
-    public float[] mPressures;
-    public Point[] mPointRadii;
-    public Rect mRect;
-    public double mX, mY, mZ;
+    private final int mType;
+    private int mAction;
+    private boolean mAckNeeded;
+    private long mTime;
+    private Point[] mPoints;
+    private int[] mPointIndicies;
+    private int mPointerIndex; // index of the point that has changed
+    private float[] mOrientations;
+    private float[] mPressures;
+    private Point[] mPointRadii;
+    private Rect mRect;
+    private double mX;
+    private double mY;
+    private double mZ;
 
-    public int mMetaState, mFlags;
-    public int mKeyCode, mUnicodeChar;
-    public int mRepeatCount;
-    public int mCount;
-    public int mStart, mEnd;
-    public String mCharacters, mCharactersExtra;
-    public int mRangeType, mRangeStyles, mRangeLineStyle;
-    public boolean mRangeBoldLine;
-    public int mRangeForeColor, mRangeBackColor, mRangeLineColor;
-    public Location mLocation;
-    public Address  mAddress;
-    public int mDomKeyLocation;
+    private int mMetaState;
+    private int mFlags;
+    private int mKeyCode;
+    private int mUnicodeChar;
+    private int mRepeatCount;
+    private int mCount;
+    private int mStart;
+    private int mEnd;
+    private String mCharacters;
+    private String mCharactersExtra;
+    private int mRangeType;
+    private int mRangeStyles;
+    private int mRangeLineStyle;
+    private boolean mRangeBoldLine;
+    private int mRangeForeColor;
+    private int mRangeBackColor;
+    private int mRangeLineColor;
+    private Location mLocation;
+    private Address mAddress;
+    private int mDomKeyLocation;
 
-    public double mBandwidth;
-    public boolean mCanBeMetered;
+    private double mBandwidth;
+    private boolean mCanBeMetered;
 
-    public int mNativeWindow;
+    private int mNativeWindow;
 
-    public short mScreenOrientation;
+    private short mScreenOrientation;
 
-    public ByteBuffer mBuffer;
+    private ByteBuffer mBuffer;
 
     private GeckoEvent(int evType) {
         mType = evType;
     }
 
     public static GeckoEvent createPauseEvent(boolean isApplicationInBackground) {
         GeckoEvent event = new GeckoEvent(ACTIVITY_PAUSING);
         event.mFlags = isApplicationInBackground ? 0 : 1;