bug 1189896 - Do not preallocate Sqlite connections caches for now. r=asuth
authorMarco Bonardo <mbonardo@mozilla.com>
Wed, 05 Aug 2015 21:54:20 +0200
changeset 288062 a65727f3f5c47f33069142bdaced3c2f67ce51ad
parent 288061 af32ff6a086c41a7e72e261d8d9e5d3b964a515b
child 288063 c9adece82ecc6d8cbbc955c731b21fdb340e7523
push id5067
push userraliiev@mozilla.com
push dateMon, 21 Sep 2015 14:04:52 +0000
treeherdermozilla-beta@14221ffe5b2f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersasuth
bugs1189896
milestone42.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1189896 - Do not preallocate Sqlite connections caches for now. r=asuth
storage/mozStorageService.cpp
--- a/storage/mozStorageService.cpp
+++ b/storage/mozStorageService.cpp
@@ -528,16 +528,20 @@ Service::initialize()
   int rc;
 
 #ifdef MOZ_STORAGE_MEMORY
   rc = ::sqlite3_config(SQLITE_CONFIG_MALLOC, &memMethods);
   if (rc != SQLITE_OK)
     return convertResultCode(rc);
 #endif
 
+  // TODO (bug 1191405): do not preallocate the connections caches until we
+  // have figured the impact on our consumers and memory.
+  sqlite3_config(SQLITE_CONFIG_PAGECACHE, NULL, 0, 0);
+
   // Explicitly initialize sqlite3.  Although this is implicitly called by
   // various sqlite3 functions (and the sqlite3_open calls in our case),
   // the documentation suggests calling this directly.  So we do.
   rc = ::sqlite3_initialize();
   if (rc != SQLITE_OK)
     return convertResultCode(rc);
 
   mSqliteVFS = ConstructTelemetryVFS();