Bug 1525818 - Remove NS_ASSERTION in ImageBridgeParent::GetInstance() r=mattwoodrow a=lizzard
authorsotaro <sotaro.ikeda.g@gmail.com>
Thu, 07 Feb 2019 20:28:30 +0000
changeset 512994 a5b7aa318e6101a6ebe071bbf374c36f5e9d9b90
parent 512993 8b10cbe1b8877f492a4d54bb7c6f5fe03b4016b2
child 512995 36ae47c3423bbcbf174f140640929fcce685d7ae
push id10672
push usernbeleuzu@mozilla.com
push dateMon, 11 Feb 2019 16:55:03 +0000
treeherdermozilla-beta@95b884dcbd6f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmattwoodrow, lizzard
bugs1525818
milestone66.0
Bug 1525818 - Remove NS_ASSERTION in ImageBridgeParent::GetInstance() r=mattwoodrow a=lizzard Sometimes NS_ASSERTION was hit during window closing. It happens because of aync architecture. It is better to change the NS_ASSERTION to NS_WARNING. Differential Revision: https://phabricator.services.mozilla.com/D18920
gfx/layers/ipc/ImageBridgeParent.cpp
--- a/gfx/layers/ipc/ImageBridgeParent.cpp
+++ b/gfx/layers/ipc/ImageBridgeParent.cpp
@@ -355,17 +355,17 @@ void ImageBridgeParent::DeferredDestroy(
 }
 
 already_AddRefed<ImageBridgeParent> ImageBridgeParent::GetInstance(
     ProcessId aId) {
   MOZ_ASSERT(CompositorThreadHolder::IsInCompositorThread());
   MonitorAutoLock lock(*sImageBridgesLock);
   ImageBridgeMap::const_iterator i = sImageBridges.find(aId);
   if (i == sImageBridges.end()) {
-    NS_ASSERTION(false, "Cannot find image bridge for process!");
+    NS_WARNING("Cannot find image bridge for process!");
     return nullptr;
   }
   RefPtr<ImageBridgeParent> bridge = i->second;
   return bridge.forget();
 }
 
 bool ImageBridgeParent::AllocShmem(size_t aSize,
                                    ipc::SharedMemory::SharedMemoryType aType,