Bug 1505685 - Part 2 - Cleanup - remove second SwitchBoard.loadConfig(); r=JanH
☠☠ backed out by 86d8ead0b9a5 ☠ ☠
authorPetru Lingurar <petru.lingurar@softvision.ro>
Wed, 21 Nov 2018 11:21:01 +0200
changeset 503948 a46710b7723fc89bc3e51b437d59f5c169bab1f6
parent 503947 9344087c8d8e0b6a2874d18684c01ffb49f6bdcd
child 503949 6e2a67a9a9c9b5d15e9231716f869fc522dfa99b
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersJanH
bugs1505685
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1505685 - Part 2 - Cleanup - remove second SwitchBoard.loadConfig(); r=JanH Summary: Executing SwitchBoard.loadConfig() on a background thread is the main purpose of the AsyncConfigLoader so executing it immediately again in the same thread is redundant. Depends on D12031 Reviewers: JanH Reviewed By: JanH Bug #: 1505685 Differential Revision: https://phabricator.services.mozilla.com/D12032
mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
--- a/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
+++ b/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
@@ -889,17 +889,16 @@ public class BrowserApp extends GeckoApp
         final String serverExtra = intent.getStringExtra(INTENT_KEY_SWITCHBOARD_SERVER);
         final String serverUrl = TextUtils.isEmpty(serverExtra) ? SWITCHBOARD_SERVER : serverExtra;
         final SwitchBoard.ConfigStatusListener configStatuslistener = mOnboardingHelper;
         final MmaDelegate.MmaVariablesChangedListener variablesChangedListener = mOnboardingHelper;
         new AsyncConfigLoader(context, serverUrl, configStatuslistener) {
             @Override
             protected Void doInBackground(Void... params) {
                 super.doInBackground(params);
-                SwitchBoard.loadConfig(context, serverUrl, configStatuslistener);
                 if (GeckoPreferences.isMmaAvailableAndEnabled(context)) {
                     // Do LeanPlum start/init here
                     MmaDelegate.init(BrowserApp.this, variablesChangedListener);
                 }
                 return null;
             }
         }.execute();
     }