Bug 1482868 - Rename connect-network-icon to globe icon;r=daisuke
authorJulian Descottes <jdescottes@mozilla.com>
Tue, 28 Aug 2018 13:43:12 +0000
changeset 488793 a3273afbe89161e13c92a2915f0e824bcc375794
parent 488792 3d7bb06312ed3e402e8c2604df3587979ef3f332
child 488794 8fd8a747cd87423a2b6938c243393157e2b0e6e4
push id9734
push usershindli@mozilla.com
push dateThu, 30 Aug 2018 12:18:07 +0000
treeherdermozilla-beta@71c71ab3afae [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdaisuke
bugs1482868
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1482868 - Rename connect-network-icon to globe icon;r=daisuke Depends on D3224 Differential Revision: https://phabricator.services.mozilla.com/D3226
devtools/client/aboutdebugging-new/src/components/ConnectPage.js
devtools/client/jar.mn
devtools/client/themes/images/aboutdebugging-connect-network-icon.svg
devtools/client/themes/images/aboutdebugging-globe-icon.svg
--- a/devtools/client/aboutdebugging-new/src/components/ConnectPage.js
+++ b/devtools/client/aboutdebugging-new/src/components/ConnectPage.js
@@ -10,17 +10,17 @@ const PropTypes = require("devtools/clie
 
 const {
   addNetworkLocation,
   removeNetworkLocation
 } = require("../modules/network-locations");
 
 const USB_ICON_SRC = "chrome://devtools/skin/images/aboutdebugging-connect-icon.svg";
 const WIFI_ICON_SRC = "chrome://devtools/skin/images/aboutdebugging-connect-icon.svg";
-const NETWORK_ICON_SRC = "chrome://devtools/skin/images/aboutdebugging-connect-network-icon.svg";
+const GLOBE_ICON_SRC = "chrome://devtools/skin/images/aboutdebugging-globe-icon.svg";
 
 class ConnectPage extends PureComponent {
   static get propTypes() {
     return {
       networkLocations: PropTypes.arrayOf(PropTypes.object).isRequired,
     };
   }
 
@@ -100,17 +100,17 @@ class ConnectPage extends PureComponent 
       },
       dom.h2(
         {
           className: "connect-page__section__title"
         },
         dom.img(
           {
             className: "connect-page__section__icon",
-            src: NETWORK_ICON_SRC
+            src: GLOBE_ICON_SRC
           }
         ),
         "Via Network Location"
       ),
       dom.ul(
         {},
         networkLocations.map(location =>
           dom.li(
--- a/devtools/client/jar.mn
+++ b/devtools/client/jar.mn
@@ -105,18 +105,18 @@ devtools.jar:
     skin/toolbox.css (themes/toolbox.css)
     skin/tooltips.css (themes/tooltips.css)
     skin/images/accessibility.svg (themes/images/accessibility.svg)
     skin/images/add.svg (themes/images/add.svg)
     skin/images/breadcrumbs-divider.svg (themes/images/breadcrumbs-divider.svg)
     skin/images/filters.svg (themes/images/filters.svg)
     skin/images/filter-swatch.svg (themes/images/filter-swatch.svg)
     skin/images/aboutdebugging-connect-icon.svg (themes/images/aboutdebugging-connect-icon.svg)
-    skin/images/aboutdebugging-connect-network-icon.svg (themes/images/aboutdebugging-connect-network-icon.svg)
     skin/images/aboutdebugging-firefox-logo.svg (themes/images/aboutdebugging-firefox-logo.svg)
+    skin/images/aboutdebugging-globe-icon.svg (themes/images/aboutdebugging-globe-icon.svg)
     skin/images/fox-smiling.svg (themes/images/fox-smiling.svg)
     skin/images/grid.svg (themes/images/grid.svg)
     skin/images/angle-swatch.svg (themes/images/angle-swatch.svg)
     skin/images/pseudo-class.svg (themes/images/pseudo-class.svg)
     skin/images/controls.png (themes/images/controls.png)
     skin/images/controls@2x.png (themes/images/controls@2x.png)
     skin/images/copy.svg (themes/images/copy.svg)
     skin/images/animation-fast-track.svg (themes/images/animation-fast-track.svg)
rename from devtools/client/themes/images/aboutdebugging-connect-network-icon.svg
rename to devtools/client/themes/images/aboutdebugging-globe-icon.svg