Back out cset 1e4f5a991728 (bug 1296887) on Aurora 51 as it introduces a pretty bad regression in the form of bug 1305969. r=backout a=gchang
authorKartikaya Gupta <kgupta@mozilla.com>
Sun, 16 Oct 2016 12:57:12 -0400
changeset 356131 a205468e405c9225f0d72303e10ce72559f7f6b4
parent 356130 f0596b7956ec3ee2bd1e329c2abfcc183fbead50
child 356132 f88c92402816b754ec154df098daf27a642228dd
push id6570
push userraliiev@mozilla.com
push dateMon, 14 Nov 2016 12:26:13 +0000
treeherdermozilla-beta@f455459b2ae5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout, gchang
bugs1296887, 1305969
milestone51.0a2
backs out1e4f5a991728ebf5ba435300406958792d2982d1
Back out cset 1e4f5a991728 (bug 1296887) on Aurora 51 as it introduces a pretty bad regression in the form of bug 1305969. r=backout a=gchang MozReview-Commit-ID: LhK4o0IBToA
mobile/android/geckoview/src/main/java/org/mozilla/gecko/gfx/DynamicToolbarAnimator.java
--- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/gfx/DynamicToolbarAnimator.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/gfx/DynamicToolbarAnimator.java
@@ -233,21 +233,16 @@ public class DynamicToolbarAnimator {
         mAnimationTask = new DynamicToolbarAnimationTask(desiredTranslation, immediately, showToolbar);
         mTarget.getView().postRenderTask(mAnimationTask);
     }
 
     private synchronized void shiftLayerView(float desiredTranslation) {
         float layerViewTranslationNeeded = desiredTranslation - mLayerViewTranslation;
         mLayerViewTranslation = desiredTranslation;
         synchronized (mTarget.getLock()) {
-            if (layerViewTranslationNeeded == 0 && isResizing()) {
-                // We're already in the middle of a snap, so this new call is
-                // redundant as it's snapping to the same place. Ignore it.
-                return;
-            }
             mHeightDuringResize = new Integer(mTarget.getViewportMetrics().viewportRectHeight);
             mSnapRequired = mTarget.setViewportSize(
                 mTarget.getView().getWidth(),
                 mTarget.getView().getHeight() - Math.round(mMaxTranslation - mLayerViewTranslation),
                 new PointF(0, -layerViewTranslationNeeded));
             if (!mSnapRequired) {
                 mHeightDuringResize = null;
                 ThreadUtils.postToUiThread(new Runnable() {