Bug 1544602 - Make media.gmp.insecure.allow an atomic. r=cpearce
authorBryce Van Dyk <bvandyk@mozilla.com>
Tue, 16 Apr 2019 22:20:10 +0000
changeset 528699 a14a4e0b60ebc2ca635bbc777474cf2fa8cbc62d
parent 528698 b978367ef7bb80e73e9c93c6234757731b5e58fb
child 528700 d969c3ed6999b34bfaa1a23bb7db115076b7f760
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscpearce
bugs1544602, 1465852
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1544602 - Make media.gmp.insecure.allow an atomic. r=cpearce Since this pref can be accessed from the GMP thread (per the bug), it should be an atomic. See bug 1465852 for the code the added the assertion hit in this bug, as well as further context as to why this should be an atomic. Differential Revision: https://phabricator.services.mozilla.com/D27831
modules/libpref/init/StaticPrefList.h
--- a/modules/libpref/init/StaticPrefList.h
+++ b/modules/libpref/init/StaticPrefList.h
@@ -1348,17 +1348,17 @@ VARCACHE_PREF(
 
 #if defined(XP_LINUX) && defined(MOZ_SANDBOX)
 // Whether to allow, on a Linux system that doesn't support the necessary
 // sandboxing features, loading Gecko Media Plugins unsandboxed.  However, EME
 // CDMs will not be loaded without sandboxing even if this pref is changed.
 VARCACHE_PREF(
   "media.gmp.insecure.allow",
    MediaGmpInsecureAllow,
-  bool, false
+  RelaxedAtomicBool, false
 )
 #endif
 
 // Specifies whether the PDMFactory can create a test decoder that just outputs
 // blank frames/audio instead of actually decoding. The blank decoder works on
 // all platforms.
 VARCACHE_PREF(
   "media.use-blank-decoder",