Bug 1424156 part 2: Don't treat message icons in the Web Console as live content for accessibility. r=nchevobbe
authorJames Teh <jteh@mozilla.com>
Wed, 03 Jan 2018 09:56:09 +1000
changeset 450115 a13e4aa506889920d674306c95eda760a2a29ffa
parent 450114 9484bc0662465437abf4b57055936c8d3aed0321
child 450116 0ba823f7ada8a7d042eb60e31614fec41e4b9739
push id8527
push userCallek@gmail.com
push dateThu, 11 Jan 2018 21:05:50 +0000
treeherdermozilla-beta@95342d212a7a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnchevobbe
bugs1424156
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1424156 part 2: Don't treat message icons in the Web Console as live content for accessibility. r=nchevobbe Message icons now get the aria-live="off" attribute. This stops screen readers from automaticaly reading icon descriptions, which might be interesting to read later but make things inefficient when automatically reading new output. MozReview-Commit-ID: BQOUnTRVkBE
devtools/client/webconsole/new-console-output/components/MessageIcon.js
--- a/devtools/client/webconsole/new-console-output/components/MessageIcon.js
+++ b/devtools/client/webconsole/new-console-output/components/MessageIcon.js
@@ -19,16 +19,17 @@ const CONSTANT_ICONS = {
   "log": getIconElement("level.log"),
   "debug": getIconElement("level.debug"),
 };
 
 function getIconElement(level) {
   return dom.span({
     className: "icon",
     title: l10n.getStr(level),
+    "aria-live": "off",
   });
 }
 
 MessageIcon.displayName = "MessageIcon";
 MessageIcon.propTypes = {
   level: PropTypes.string.isRequired,
 };
 function MessageIcon(props) {