bug 1272503 - make alerting for changes in num_constructors more agressive r=froydnj f=wlach
authorTrevor Saunders <tbsaunde@tbsaunde.org>
Thu, 12 May 2016 18:09:12 -0400
changeset 338807 a0ecfb9c274386956d390493efe732d184a922dc
parent 338806 47dfe258f4b427d1c9e316f462d6eaaece775959
child 338808 092c8795c47a04bb8fd96499847198537c144258
push id6249
push userjlund@mozilla.com
push dateMon, 01 Aug 2016 13:59:36 +0000
treeherdermozilla-beta@bad9d4f5bf7e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1272503
milestone49.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1272503 - make alerting for changes in num_constructors more agressive r=froydnj f=wlach There shouldn't be any noise in this number, either a patch adds or removes constructors or it doesn't. Choosing 0.25% is kind of arbitrary, but it should be good enough since it will make us alert for an increase of one constructor so long as we have less than 400 constructors, and currently we have 98.
build/util/count_ctors.py
--- a/build/util/count_ctors.py
+++ b/build/util/count_ctors.py
@@ -50,14 +50,15 @@ def count_ctors(filename):
 if __name__ == '__main__':
     for f in sys.argv[1:]:
         perfherder_data = {
             "framework": {"name": "build_metrics"},
             "suites": [{
                 "name": "compiler_metrics",
                 "subtests": [{
                     "name": "num_constructors",
-                    "value": count_ctors(f)
+                    "value": count_ctors(f),
+                    "alertThreshold": 0.25
                 }]}
             ]
         }
         print "PERFHERDER_DATA: %s" % json.dumps(perfherder_data)