Bug 1583985 - move breach alerts checkbox in markup to avoid its width enlarging the content box unnecessarily, r?MattN,jaws a=lizzard
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Mon, 30 Sep 2019 13:04:29 +0300
changeset 552153 a0d36046f60deb3f25336915332b0e83a509adcc
parent 552152 7894b0884d01d5e6e93ed85ec14bf0890dc195b0
child 552154 2e2d5a0f2a5f85f7bb7b83c8e70aca500048c135
push id12071
push userdluca@mozilla.com
push dateMon, 30 Sep 2019 10:17:10 +0000
treeherdermozilla-beta@2e2d5a0f2a5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersMattN, jaws, lizzard
bugs1583985
milestone70.0
Bug 1583985 - move breach alerts checkbox in markup to avoid its width enlarging the content box unnecessarily, r?MattN,jaws a=lizzard Reviewers: MattN, jaws Reviewed By: MattN Bug #: 1583985 Differential Revision: https://phabricator.services.mozilla.com/D47187
browser/components/preferences/in-content/privacy.inc.xul
--- a/browser/components/preferences/in-content/privacy.inc.xul
+++ b/browser/components/preferences/in-content/privacy.inc.xul
@@ -447,25 +447,16 @@
         </hbox>
         <hbox class="indent" id="generatePasswordsBox" flex="1">
           <checkbox id="generatePasswords"
                     data-l10n-id="forms-generate-passwords"
                     search-l10n-ids="forms-generate-passwords.label"
                     preference="signon.generation.enabled"
                     flex="1" />
         </hbox>
-        <hbox class="indent" id="breachAlertsBox" flex="1" align="center">
-          <checkbox id="breachAlerts"
-                    class="tail-with-learn-more"
-                    data-l10n-id="forms-breach-alerts"
-                    search-l10n-ids="breach-alerts.label"
-                    preference="signon.management.page.breach-alerts.enabled"/>
-          <label id="breachAlertsLearnMoreLink" class="learnMore" is="text-link"
-              data-l10n-id="forms-breach-alerts-learn-more-link"/>
-        </hbox>
       </vbox>
       <vbox>
         <!-- Please don't remove the wrapping hbox/vbox/box for these elements. It's used to properly compute the search tooltip position. -->
         <hbox>
           <button id="passwordExceptions"
                   is="highlightable-button"
                   class="accessory-button"
                   data-l10n-id="forms-exceptions"
@@ -482,16 +473,29 @@
                   is="highlightable-button"
                   class="accessory-button"
                   data-l10n-id="forms-saved-logins"
                   search-l10n-ids="forms-saved-logins.label"
                   preference="pref.privacy.disable_button.view_passwords"/>
         </hbox>
       </vbox>
     </hbox>
+    <hbox>
+      <vbox flex="1">
+        <hbox class="indent" id="breachAlertsBox" flex="1" align="center">
+          <checkbox id="breachAlerts"
+                    class="tail-with-learn-more"
+                    data-l10n-id="forms-breach-alerts"
+                    search-l10n-ids="breach-alerts.label"
+                    preference="signon.management.page.breach-alerts.enabled"/>
+          <label id="breachAlertsLearnMoreLink" class="learnMore" is="text-link"
+                 data-l10n-id="forms-breach-alerts-learn-more-link"/>
+        </hbox>
+      </vbox>
+    </hbox>
   </vbox>
   <hbox id="masterPasswordRow">
     <checkbox id="useMasterPassword"
               data-l10n-id="forms-master-pw-use"
               flex="1"/>
     <!-- Please don't remove the wrapping hbox/vbox/box for these elements. It's used to properly compute the search tooltip position. -->
     <hbox>
       <button id="changeMasterPassword"