Bug 919516 - No need to account for header views in Bookmarks page. r=mfinkle, a=lsblakk
authorLucas Rocha <lucasr@mozilla.com>
Wed, 02 Oct 2013 15:46:13 +0100
changeset 160656 a088f42b312b1531602ec12d6327e2b60d8e8c6e
parent 160655 e391dad00380f2c15af336d3c75e086f0a66ec4e
child 160657 290d6d1241d57a474163ffd6a678b3681b0cf589
push id2961
push userlsblakk@mozilla.com
push dateMon, 28 Oct 2013 21:59:28 +0000
treeherdermozilla-beta@73ef4f13486f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmfinkle, lsblakk
bugs919516
milestone26.0a2
Bug 919516 - No need to account for header views in Bookmarks page. r=mfinkle, a=lsblakk
mobile/android/base/home/BookmarksListView.java
--- a/mobile/android/base/home/BookmarksListView.java
+++ b/mobile/android/base/home/BookmarksListView.java
@@ -57,27 +57,16 @@ public class BookmarksListView extends H
                 }
                 return false;
             }
         });
     }
 
     @Override
     public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
-        final ListView list = (ListView) parent;
-        final int headerCount = list.getHeaderViewsCount();
-
-        if (position < headerCount) {
-            // The click is on a header, don't do anything.
-            return;
-        }
-
-        // Absolute position for the adapter.
-        position -= headerCount;
-
         final BookmarksListAdapter adapter = getBookmarksListAdapter();
         if (adapter.isShowingChildFolder()) {
             if (position == 0) {
                 // If we tap on an opened folder, move back to parent folder.
                 adapter.moveToParentFolder();
                 return;
             }