Bug 1373449 Treat complete themes as legacy extensions r=rhelmer
authorAndrew Swan <aswan@mozilla.com>
Sat, 22 Jul 2017 19:37:48 -0700
changeset 419411 a05e8758316f1cdfc078cd30866cda481c94c115
parent 419410 32747028f0ac7cb05f8c9e1261cb12dd47fce461
child 419412 ef4d1461791e38d3730fc8e43aee0e871e83333c
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrhelmer
bugs1373449
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1373449 Treat complete themes as legacy extensions r=rhelmer MozReview-Commit-ID: I1AH07QSLNK
toolkit/mozapps/extensions/internal/XPIProvider.jsm
toolkit/mozapps/extensions/test/xpcshell/test_legacy.js
--- a/toolkit/mozapps/extensions/internal/XPIProvider.jsm
+++ b/toolkit/mozapps/extensions/internal/XPIProvider.jsm
@@ -260,16 +260,17 @@ const SIGNED_TYPES = new Set([
   "experiment",
   "webextension",
   "webextension-theme",
 ]);
 
 const LEGACY_TYPES = new Set([
   "apiextension",
   "extension",
+  "theme",
 ]);
 
 const ALL_EXTERNAL_TYPES = new Set([
   "dictionary",
   "extension",
   "experiment",
   "locale",
   "theme",
--- a/toolkit/mozapps/extensions/test/xpcshell/test_legacy.js
+++ b/toolkit/mozapps/extensions/test/xpcshell/test_legacy.js
@@ -14,16 +14,23 @@ add_task(async function test_disable() {
       multiprocessCompatible: true,
     },
     {
       id: "apiexperiment@tests.mozilla.org",
       name: "WebExtension Experiment",
       version: "1.0",
       type: 256,
     },
+    {
+      id: "theme@tests.mozilla.org",
+      name: "Theme",
+      version: "1.0",
+      type: 4,
+      internalName: "mytheme/1.0",
+    },
   ];
 
   let nonLegacy = [
     {
       id: "webextension@tests.mozilla.org",
       manifest: {
         applications: {gecko: {id: "webextension@tests.mozilla.org"}},
       },