Bug 1552321 - Use logStringMessage instead of reportError for the 'Unable to read app update configuration file' log message. r=bytesized
authorRobert Strong <robert.bugzilla@gmail.com>
Thu, 16 May 2019 21:45:40 +0000
changeset 533045 a012ed03628d6192c71ab1561e8dc978c81e9136
parent 533044 296ca33d9a0e4bd501df7db94fac65961c7acec5
child 533046 3f0b0cb94a5879f083dbee48f5db8270d05ae15f
push id11276
push userrgurzau@mozilla.com
push dateMon, 20 May 2019 13:11:24 +0000
treeherdermozilla-beta@847755a7c325 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbytesized
bugs1552321
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1552321 - Use logStringMessage instead of reportError for the 'Unable to read app update configuration file' log message. r=bytesized There have been several people that thought app update was broken because this message was reported as an error so just use logStringMessage Differential Revision: https://phabricator.services.mozilla.com/D31524
toolkit/modules/UpdateUtils.jsm
--- a/toolkit/modules/UpdateUtils.jsm
+++ b/toolkit/modules/UpdateUtils.jsm
@@ -172,18 +172,21 @@ var UpdateUtils = {
       try {
         let configValue = await readUpdateAutoConfig();
         // If we read a value out of this file, don't later perform migration.
         // If the file is deleted, we don't want some stale pref getting
         // written to it just because a different profile performed migration.
         Services.prefs.setBoolPref(PREF_APP_UPDATE_AUTO_MIGRATED, true);
         return configValue;
       } catch (e) {
-        Cu.reportError("UpdateUtils.getAppUpdateAutoEnabled - Unable to read " +
-                       "app update configuration file. Exception: " + e);
+        // Not being able to read from the app update configuration file is not
+        // a serious issue so use logStringMessage to avoid concern from users.
+        Services.console.logStringMessage(
+          "UpdateUtils.getAppUpdateAutoEnabled - Unable to read app update " +
+          "configuration file. Exception: " + e);
         let valueMigrated = Services.prefs.getBoolPref(
                               PREF_APP_UPDATE_AUTO_MIGRATED,
                               false);
         if (!valueMigrated) {
           Services.prefs.setBoolPref(PREF_APP_UPDATE_AUTO_MIGRATED, true);
           let prefValue = Services.prefs.getBoolPref(PREF_APP_UPDATE_AUTO,
                                                      DEFAULT_APP_UPDATE_AUTO);
           try {