Bug 1362611 - Fix packager quoting in the installer. r=mshal, a=release a=jorgk DONTBUILD THUNDERBIRD540b1_2017051801_RELBRANCH THUNDERBIRD_54_0b1_BUILD3 THUNDERBIRD_54_0b1_RELEASE
authorRonald Claveau <sousmangoosta@ovh.fr>
Tue, 16 May 2017 21:57:59 +0200
branchTHUNDERBIRD540b1_2017051801_RELBRANCH
changeset 394000 d90815ce77ddd71b4516f85be33b69daf42d696a
parent 393996 01e7773bf3e2cabd7ecc8f1cd0519277e401a813
child 394001 8ff7d34dd93463c54da265aae07358db372cda55
push id7327
push usermozilla@jorgk.com
push dateThu, 18 May 2017 18:19:03 +0000
treeherdermozilla-beta@d90815ce77dd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmshal, release, jorgk
bugs1362611
milestone54.0
Bug 1362611 - Fix packager quoting in the installer. r=mshal, a=release a=jorgk DONTBUILD This patch fixes the upload/packaging build step for Thunderbird beta builds MozReview-Commit-ID: K2qcZ4pLvtN
toolkit/mozapps/installer/upload-files.mk
--- a/toolkit/mozapps/installer/upload-files.mk
+++ b/toolkit/mozapps/installer/upload-files.mk
@@ -110,23 +110,23 @@ endif
 
 ifeq ($(MOZ_PKG_FORMAT),ZIP)
   ifdef MOZ_EXTERNAL_SIGNING_FORMAT
     # We can't use sha2signcode on zip files
     MOZ_EXTERNAL_SIGNING_FORMAT := $(filter-out sha2signcode,$(MOZ_EXTERNAL_SIGNING_FORMAT))
   endif
   PKG_SUFFIX	= .zip
   INNER_MAKE_PACKAGE = $(call py_action,make_zip,'$(MOZ_PKG_DIR)' '$(PACKAGE)')
-  INNER_UNMAKE_PACKAGE = $(call py_action,make_unzip,'$(UNPACKAGE)')
+  INNER_UNMAKE_PACKAGE = $(call py_action,make_unzip,$(UNPACKAGE))
 endif
 
 ifeq ($(MOZ_PKG_FORMAT),SFX7Z)
   PKG_SUFFIX	= .exe
   INNER_MAKE_PACKAGE = $(call py_action,7z_exe_archive,'$(MOZ_PKG_DIR)' '$(MOZ_INSTALLER_PATH)/app.tag' '$(MOZ_SFX_PACKAGE)' '$(PACKAGE)')
-  INNER_UNMAKE_PACKAGE = $(call py_action,7z_exe_extract,'$(UNPACKAGE)' '$(MOZ_PKG_DIR)')
+  INNER_UNMAKE_PACKAGE = $(call py_action,7z_exe_extract,$(UNPACKAGE) $(MOZ_PKG_DIR))
 endif
 
 #Create an RPM file
 ifeq ($(MOZ_PKG_FORMAT),RPM)
   PKG_SUFFIX  = .rpm
   MOZ_NUMERIC_APP_VERSION = $(shell echo $(MOZ_PKG_VERSION) | sed 's/[^0-9.].*//' )
   MOZ_RPM_RELEASE = $(shell echo $(MOZ_PKG_VERSION) | sed 's/[0-9.]*//' )