Bug 1559131 - Add skip-if=require_signing to test_recommendations.js. r=rpl, a=test-only DEVEDITION_68_0b11_BUILD1 DEVEDITION_68_0b11_RELEASE FENNEC_68_0b11_BUILD1 FENNEC_68_0b11_RELEASE FIREFOX_68_0b11_BUILD1 FIREFOX_68_0b11_RELEASE
authorRob Wu <rob@robwu.nl>
Thu, 13 Jun 2019 15:14:34 +0000
changeset 533927 60f0c79f0f53fcbe5941d01423e6409f8ea1df0f
parent 533926 52dbf56c513ce3c74033a3b8d0d47483dd868df5
child 533928 fd938072ebb4457c6c597815b2deb7065877a992
child 533934 4fa4f8ba3728ac6bf6813be800880f0f0dca5288
push id11463
push userjcristau@mozilla.com
push dateMon, 17 Jun 2019 17:28:38 +0000
treeherdermozilla-beta@60f0c79f0f53 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrpl, test-only
bugs1559131
milestone68.0
Bug 1559131 - Add skip-if=require_signing to test_recommendations.js. r=rpl, a=test-only test_recommendations.js has one test that verifies that an unsigned add-on is not recommended. In order to load an unsigned add-on, it needs to disable signing. Signing can however not be disabled when MOZ_REQUIRE_SIGNING=1. So skip the test if require_signing is set. Differential Revision: https://phabricator.services.mozilla.com/D34891
toolkit/mozapps/extensions/test/xpcshell/xpcshell.ini
--- a/toolkit/mozapps/extensions/test/xpcshell/xpcshell.ini
+++ b/toolkit/mozapps/extensions/test/xpcshell/xpcshell.ini
@@ -73,16 +73,17 @@ skip-if = os == "android"
 [test_pref_properties.js]
 [test_provider_markSafe.js]
 [test_provider_shutdown.js]
 [test_provider_unsafe_access_shutdown.js]
 [test_provider_unsafe_access_startup.js]
 [test_proxies.js]
 skip-if = require_signing
 [test_recommendations.js]
+skip-if = require_signing
 [test_registerchrome.js]
 [test_registry.js]
 skip-if = os != 'win'
 [test_reinstall_disabled_addon.js]
 [test_reload.js]
 # Bug 676992: test consistently hangs on Android
 # There's a problem removing a temp file without manually clearing the cache on Windows
 skip-if = os == "android" || os == "win"