Backed out 2 changesets (bug 1303469) for unexpected file access failures in xperf
authorPhil Ringnalda <philringnalda@gmail.com>
Sat, 17 Sep 2016 09:13:36 -0700
changeset 355567 9fcea68f98ef58e2e00e1c529c4ed2ca629759a3
parent 355566 0c940935107540f80c46da8a1aa2cbbc070f702b
child 355568 722dadacc2d57d2ecb1dadf7b9904802f6567183
push id6570
push userraliiev@mozilla.com
push dateMon, 14 Nov 2016 12:26:13 +0000
treeherdermozilla-beta@f455459b2ae5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1303469
milestone51.0a1
backs out86b10c4dce3bbfc3fc42daa1d0f21f8433e1c0f9
03f631f0fca7d908f954d3a36faa18d087b28212
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out 2 changesets (bug 1303469) for unexpected file access failures in xperf Backed out changeset 86b10c4dce3b (bug 1303469) Backed out changeset 03f631f0fca7 (bug 1303469)
browser/extensions/formautofill/.eslintrc
browser/extensions/formautofill/bootstrap.js
browser/extensions/formautofill/install.rdf.in
browser/extensions/formautofill/moz.build
browser/extensions/formautofill/test/browser/.eslintrc
browser/extensions/formautofill/test/browser/browser.ini
browser/extensions/formautofill/test/browser/browser_check_installed.js
browser/extensions/moz.build
browser/extensions/webcompat/install.rdf.in
deleted file mode 100644
--- a/browser/extensions/formautofill/.eslintrc
+++ /dev/null
@@ -1,473 +0,0 @@
-{
-  "extends": "../../.eslintrc",
-
-  "globals": {
-    "Components": true,
-    "dump": true,
-    "TextDecoder": false,
-    "TextEncoder": false,
-  },
-
-  "rules": {
-    // Rules from the mozilla plugin
-    "mozilla/balanced-listeners": 2,
-    "mozilla/mark-test-function-used": 1,
-    "mozilla/no-aArgs": 1,
-    "mozilla/no-cpows-in-tests": 1,
-    "mozilla/var-only-at-top-level": 1,
-
-    "valid-jsdoc": [2, {
-      "prefer": {
-        "return": "returns",
-      },
-      "preferType": {
-        "Boolean": "boolean",
-        "Number": "number",
-        "String": "string",
-        "bool": "boolean",
-      },
-      "requireParamDescription": false,
-      "requireReturn": false,
-      "requireReturnDescription": false,
-    }],
-
-    // Braces only needed for multi-line arrow function blocks
-    // "arrow-body-style": [2, "as-needed"],
-
-    // Require spacing around =>
-    "arrow-spacing": 2,
-
-    // Always require spacing around a single line block
-    "block-spacing": 1,
-
-    // Forbid spaces inside the square brackets of array literals.
-    "array-bracket-spacing": [2, "never"],
-
-    // Forbid spaces inside the curly brackets of object literals.
-    "object-curly-spacing": [2, "never"],
-
-    // No space padding in parentheses
-    "space-in-parens": [2, "never"],
-
-    // Enforce one true brace style (opening brace on the same line) and avoid
-    // start and end braces on the same line.
-    "brace-style": [2, "1tbs", {"allowSingleLine": true}],
-
-    // No space before always a space after a comma
-    "comma-spacing": [2, {"before": false, "after": true}],
-
-    // Commas at the end of the line not the start
-    "comma-style": 2,
-
-    // Don't require spaces around computed properties
-    "computed-property-spacing": [1, "never"],
-
-    // Functions are not required to consistently return something or nothing
-    "consistent-return": 0,
-
-    // Require braces around blocks that start a new line
-    "curly": [2, "all"],
-
-    // Always require a trailing EOL
-    "eol-last": 2,
-
-    // Require function* name()
-    "generator-star-spacing": [2, {"before": false, "after": true}],
-
-    // Two space indent
-    "indent": [2, 2, {"SwitchCase": 1}],
-
-    // Space after colon not before in property declarations
-    "key-spacing": [2, {"beforeColon": false, "afterColon": true, "mode": "minimum"}],
-
-    // Require spaces before and after finally, catch, etc.
-    "keyword-spacing": 2,
-
-    // Unix linebreaks
-    "linebreak-style": [2, "unix"],
-
-    // Always require parenthesis for new calls
-    "new-parens": 2,
-
-    // Use [] instead of Array()
-    "no-array-constructor": 2,
-
-    // No duplicate arguments in function declarations
-    "no-dupe-args": 2,
-
-    // No duplicate keys in object declarations
-    "no-dupe-keys": 2,
-
-    // No duplicate cases in switch statements
-    "no-duplicate-case": 2,
-
-    // If an if block ends with a return no need for an else block
-    // "no-else-return": 2,
-
-    // Disallow empty statements. This will report an error for:
-    // try { something(); } catch (e) {}
-    // but will not report it for:
-    // try { something(); } catch (e) { /* Silencing the error because ...*/ }
-    // which is a valid use case.
-    "no-empty": 2,
-
-    // No empty character classes in regex
-    "no-empty-character-class": 2,
-
-    // Disallow empty destructuring
-    "no-empty-pattern": 2,
-
-    // No assiging to exception variable
-    "no-ex-assign": 2,
-
-    // No using !! where casting to boolean is already happening
-    "no-extra-boolean-cast": 1,
-
-    // No double semicolon
-    "no-extra-semi": 2,
-
-    // No overwriting defined functions
-    "no-func-assign": 2,
-
-    // No invalid regular expresions
-    "no-invalid-regexp": 2,
-
-    // No odd whitespace characters
-    "no-irregular-whitespace": 2,
-
-    // No single if block inside an else block
-    "no-lonely-if": 1,
-
-    // No mixing spaces and tabs in indent
-    "no-mixed-spaces-and-tabs": [2, "smart-tabs"],
-
-    // Disallow use of multiple spaces (sometimes used to align const values,
-    // array or object items, etc.). It's hard to maintain and doesn't add that
-    // much benefit.
-    "no-multi-spaces": 1,
-
-    // No reassigning native JS objects
-    "no-native-reassign": 2,
-
-    // No (!foo in bar)
-    "no-negated-in-lhs": 2,
-
-    // Nested ternary statements are confusing
-    "no-nested-ternary": 2,
-
-    // Use {} instead of new Object()
-    "no-new-object": 2,
-
-    // No Math() or JSON()
-    "no-obj-calls": 2,
-
-    // No octal literals
-    "no-octal": 2,
-
-    // No redeclaring variables
-    "no-redeclare": 2,
-
-    // No unnecessary comparisons
-    "no-self-compare": 2,
-
-    // No spaces between function name and parentheses
-    "no-spaced-func": 1,
-
-    // No trailing whitespace
-    "no-trailing-spaces": 2,
-
-    // Error on newline where a semicolon is needed
-    "no-unexpected-multiline": 2,
-
-    // No unreachable statements
-    "no-unreachable": 2,
-
-    // No expressions where a statement is expected
-    "no-unused-expressions": 2,
-
-    // No declaring variables that are never used
-    "no-unused-vars": [2, {"args": "none", "varsIgnorePattern": "^(Cc|Ci|Cr|Cu|EXPORTED_SYMBOLS)$"}],
-
-    // No using variables before defined
-    "no-use-before-define": 2,
-
-    // No using with
-    "no-with": 2,
-
-    // Always require semicolon at end of statement
-    "semi": [2, "always"],
-
-    // Require space before blocks
-    "space-before-blocks": 2,
-
-    // Never use spaces before function parentheses
-    "space-before-function-paren": [2, {"anonymous": "never", "named": "never"}],
-
-    // Require spaces around operators, except for a|0.
-    "space-infix-ops": [2, {"int32Hint": true}],
-
-    // ++ and -- should not need spacing
-    "space-unary-ops": [1, {"nonwords": false}],
-
-    // No comparisons to NaN
-    "use-isnan": 2,
-
-    // Only check typeof against valid results
-    "valid-typeof": 2,
-
-    // Disallow using variables outside the blocks they are defined (especially
-    // since only let and const are used, see "no-var").
-    "block-scoped-var": 2,
-
-    // Allow trailing commas for easy list extension.  Having them does not
-    // impair readability, but also not required either.
-    "comma-dangle": [2, "always-multiline"],
-
-    // Warn about cyclomatic complexity in functions.
-    "complexity": 1,
-
-    // Don't warn for inconsistent naming when capturing this (not so important
-    // with auto-binding fat arrow functions).
-    // "consistent-this": [2, "self"],
-
-    // Don't require a default case in switch statements. Avoid being forced to
-    // add a bogus default when you know all possible cases are handled.
-    "default-case": 0,
-
-    // Enforce dots on the next line with property name.
-    "dot-location": [2, "property"],
-
-    // Encourage the use of dot notation whenever possible.
-    "dot-notation": 2,
-
-    // Allow using == instead of ===, in the interest of landing something since
-    // the devtools codebase is split on convention here.
-    "eqeqeq": 0,
-
-    // Don't require function expressions to have a name.
-    // This makes the code more verbose and hard to read. Our engine already
-    // does a fantastic job assigning a name to the function, which includes
-    // the enclosing function name, and worst case you have a line number that
-    // you can just look up.
-    "func-names": 0,
-
-    // Allow use of function declarations and expressions.
-    "func-style": 0,
-
-    // Don't enforce the maximum depth that blocks can be nested. The complexity
-    // rule is a better rule to check this.
-    "max-depth": 0,
-
-    // Maximum length of a line.
-    // Disabled because we exceed this in too many places.
-    "max-len": [0, 80],
-
-    // Maximum depth callbacks can be nested.
-    "max-nested-callbacks": [2, 4],
-
-    // Don't limit the number of parameters that can be used in a function.
-    "max-params": 0,
-
-    // Don't limit the maximum number of statement allowed in a function. We
-    // already have the complexity rule that's a better measurement.
-    "max-statements": 0,
-
-    // Don't require a capital letter for constructors, only check if all new
-    // operators are followed by a capital letter. Don't warn when capitalized
-    // functions are used without the new operator.
-    "new-cap": [0, {"capIsNew": false}],
-
-    // Allow use of bitwise operators.
-    "no-bitwise": 0,
-
-    // Disallow use of arguments.caller or arguments.callee.
-    "no-caller": 2,
-
-    // Disallow the catch clause parameter name being the same as a variable in
-    // the outer scope, to avoid confusion.
-    "no-catch-shadow": 0,
-
-    // Disallow assignment in conditional expressions.
-    "no-cond-assign": 2,
-
-    // Disallow using the console API.
-    "no-console": 2,
-
-    // Allow using constant expressions in conditions like while (true)
-    "no-constant-condition": 0,
-
-    // Allow use of the continue statement.
-    "no-continue": 0,
-
-    // Disallow control characters in regular expressions.
-    "no-control-regex": 2,
-
-    // Disallow use of debugger.
-    "no-debugger": 2,
-
-    // Disallow deletion of variables (deleting properties is fine).
-    "no-delete-var": 2,
-
-    // Allow division operators explicitly at beginning of regular expression.
-    "no-div-regex": 0,
-
-    // Disallow use of eval(). We have other APIs to evaluate code in content.
-    "no-eval": 2,
-
-    // Disallow adding to native types
-    "no-extend-native": 2,
-
-    // Disallow unnecessary function binding.
-    "no-extra-bind": 2,
-
-    // Allow unnecessary parentheses, as they may make the code more readable.
-    "no-extra-parens": 0,
-
-    // Disallow fallthrough of case statements, except if there is a comment.
-    "no-fallthrough": 2,
-
-    // Allow the use of leading or trailing decimal points in numeric literals.
-    "no-floating-decimal": 0,
-
-    // Allow comments inline after code.
-    "no-inline-comments": 0,
-
-    // Disallow use of labels for anything other then loops and switches.
-    "no-labels": [2, { "allowLoop": true }],
-
-    // Disallow use of multiline strings (use template strings instead).
-    "no-multi-str": 1,
-
-    // Disallow multiple empty lines.
-    "no-multiple-empty-lines": [1, {"max": 2}],
-
-    // Allow reassignment of function parameters.
-    "no-param-reassign": 0,
-
-    // Allow string concatenation with __dirname and __filename (not a node env).
-    "no-path-concat": 0,
-
-    // Allow use of unary operators, ++ and --.
-    "no-plusplus": 0,
-
-    // Allow using process.env (not a node environment).
-    "no-process-env": 0,
-
-    // Allow using process.exit (not a node environment).
-    "no-process-exit": 0,
-
-    // Disallow usage of __proto__ property.
-    "no-proto": 2,
-
-    // Disallow multiple spaces in a regular expression literal.
-    "no-regex-spaces": 2,
-
-    // Allow reserved words being used as object literal keys.
-    "no-reserved-keys": 0,
-
-    // Don't restrict usage of specified node modules (not a node environment).
-    "no-restricted-modules": 0,
-
-    // Disallow use of assignment in return statement. It is preferable for a
-    // single line of code to have only one easily predictable effect.
-    "no-return-assign": 2,
-
-    // Don't warn about declaration of variables already declared in the outer scope.
-    "no-shadow": 0,
-
-    // Disallow shadowing of names such as arguments.
-    "no-shadow-restricted-names": 2,
-
-    // Allow use of synchronous methods (not a node environment).
-    "no-sync": 0,
-
-    // Allow the use of ternary operators.
-    "no-ternary": 0,
-
-    // Disallow throwing literals (eg. throw "error" instead of
-    // throw new Error("error")).
-    "no-throw-literal": 2,
-
-    // Disallow use of undeclared variables unless mentioned in a /* global */
-    // block. Note that globals from head.js are automatically imported in tests
-    // by the import-headjs-globals rule form the mozilla eslint plugin.
-    "no-undef": 2,
-
-    // Allow dangling underscores in identifiers (for privates).
-    "no-underscore-dangle": 0,
-
-    // Allow use of undefined variable.
-    "no-undefined": 0,
-
-    // Disallow the use of Boolean literals in conditional expressions.
-    "no-unneeded-ternary": 2,
-
-    // We use var-only-at-top-level instead of no-var as we allow top level
-    // vars.
-    "no-var": 0,
-
-    // Allow using TODO/FIXME comments.
-    "no-warning-comments": 0,
-
-    // Don't require method and property shorthand syntax for object literals.
-    // We use this in the code a lot, but not consistently, and this seems more
-    // like something to check at code review time.
-    "object-shorthand": 0,
-
-    // Allow more than one variable declaration per function.
-    "one-var": 0,
-
-    // Disallow padding within blocks.
-    "padded-blocks": [1, "never"],
-
-    // Don't require quotes around object literal property names.
-    "quote-props": 0,
-
-    // Double quotes should be used.
-    "quotes": [1, "double", {"avoidEscape": true, "allowTemplateLiterals": true}],
-
-    // Require use of the second argument for parseInt().
-    "radix": 2,
-
-    // Enforce spacing after semicolons.
-    "semi-spacing": [2, {"before": false, "after": true}],
-
-    // Don't require to sort variables within the same declaration block.
-    // Anyway, one-var is disabled.
-    "sort-vars": 0,
-
-    // Require a space immediately following the // in a line comment.
-    "spaced-comment": [2, "always"],
-
-    // Require "use strict" to be defined globally in the script.
-    "strict": [2, "global"],
-
-    // Allow vars to be declared anywhere in the scope.
-    "vars-on-top": 0,
-
-    // Don't require immediate function invocation to be wrapped in parentheses.
-    "wrap-iife": 0,
-
-    // Don't require regex literals to be wrapped in parentheses (which
-    // supposedly prevent them from being mistaken for division operators).
-    "wrap-regex": 0,
-
-    // Disallow Yoda conditions (where literal value comes first).
-    "yoda": 2,
-
-    // disallow use of eval()-like methods
-    "no-implied-eval": 2,
-
-    // Disallow function or variable declarations in nested blocks
-    "no-inner-declarations": 2,
-
-    // Disallow usage of __iterator__ property
-    "no-iterator": 2,
-
-    // Disallow labels that share a name with a variable
-    "no-label-var": 2,
-
-    // Disallow creating new instances of String, Number, and Boolean
-    "no-new-wrappers": 2,
-  }
-}
deleted file mode 100644
--- a/browser/extensions/formautofill/bootstrap.js
+++ /dev/null
@@ -1,12 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-
-"use strict";
-
-/* exported startup, shutdown, install, uninstall */
-
-function startup() {}
-function shutdown() {}
-function install() {}
-function uninstall() {}
deleted file mode 100644
--- a/browser/extensions/formautofill/install.rdf.in
+++ /dev/null
@@ -1,32 +0,0 @@
-<?xml version="1.0"?>
-<!-- This Source Code Form is subject to the terms of the Mozilla Public
-   - License, v. 2.0. If a copy of the MPL was not distributed with this
-   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
-
-#filter substitution
-
-<RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
-     xmlns:em="http://www.mozilla.org/2004/em-rdf#">
-
-  <Description about="urn:mozilla:install-manifest">
-    <em:id>formautofill@mozilla.org</em:id>
-    <em:version>1.0</em:version>
-    <em:type>2</em:type>
-    <em:bootstrap>true</em:bootstrap>
-    <em:multiprocessCompatible>true</em:multiprocessCompatible>
-
-    <!-- Target Application this extension can install into,
-        with minimum and maximum supported versions. -->
-    <em:targetApplication>
-      <Description>
-        <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
-        <em:minVersion>@MOZ_APP_VERSION@</em:minVersion>
-        <em:maxVersion>@MOZ_APP_MAXVERSION@</em:maxVersion>
-      </Description>
-    </em:targetApplication>
-
-    <!-- Front End MetaData -->
-    <em:name>Form Autofill</em:name>
-    <em:description>Autofill forms with saved profiles</em:description>
-  </Description>
-</RDF>
deleted file mode 100644
--- a/browser/extensions/formautofill/moz.build
+++ /dev/null
@@ -1,18 +0,0 @@
-# -*- Mode: python; indent-tabs-mode: nil; tab-width: 40 -*-
-# vim: set filetype=python:
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-
-DEFINES['MOZ_APP_VERSION'] = CONFIG['MOZ_APP_VERSION']
-DEFINES['MOZ_APP_MAXVERSION'] = CONFIG['MOZ_APP_MAXVERSION']
-
-FINAL_TARGET_FILES.features['formautofill@mozilla.org'] += [
-  'bootstrap.js'
-]
-
-FINAL_TARGET_PP_FILES.features['formautofill@mozilla.org'] += [
-  'install.rdf.in'
-]
-
-BROWSER_CHROME_MANIFESTS += ['test/browser/browser.ini']
deleted file mode 100644
--- a/browser/extensions/formautofill/test/browser/.eslintrc
+++ /dev/null
@@ -1,5 +0,0 @@
-{
-  "extends": [
-    "../../../../../testing/mochitest/browser.eslintrc"
-  ]
-}
deleted file mode 100644
--- a/browser/extensions/formautofill/test/browser/browser.ini
+++ /dev/null
@@ -1,3 +0,0 @@
-[DEFAULT]
-
-[browser_check_installed.js]
deleted file mode 100644
--- a/browser/extensions/formautofill/test/browser/browser_check_installed.js
+++ /dev/null
@@ -1,14 +0,0 @@
-"use strict";
-
-add_task(function* test_enabled() {
-  let addon = yield new Promise(
-    resolve => AddonManager.getAddonByID("formautofill@mozilla.org", resolve)
-  );
-  isnot(addon, null, "Check addon exists");
-  is(addon.version, "1.0", "Check version");
-  is(addon.name, "Form Autofill", "Check name");
-  ok(addon.isCompatible, "Check application compatibility");
-  ok(!addon.appDisabled, "Check not app disabled");
-  ok(addon.isActive, "Check addon is active");
-  is(addon.type, "extension", "Check type is 'extension'");
-});
--- a/browser/extensions/moz.build
+++ b/browser/extensions/moz.build
@@ -10,10 +10,9 @@ DIRS += [
     'pocket',
     'webcompat',
 ]
 
 # Only include the following system add-ons if building Aurora or Nightly
 if 'a' in CONFIG['GRE_MILESTONE']:
     DIRS += [
         'flyweb',
-        'formautofill',
     ]
--- a/browser/extensions/webcompat/install.rdf.in
+++ b/browser/extensions/webcompat/install.rdf.in
@@ -10,17 +10,17 @@
 
   <Description about="urn:mozilla:install-manifest">
     <em:id>webcompat@mozilla.org</em:id>
     <em:version>1.0</em:version>
     <em:type>2</em:type>
     <em:bootstrap>true</em:bootstrap>
     <em:multiprocessCompatible>true</em:multiprocessCompatible>
 
-    <!-- Target Application this extension can install into,
+    <!-- Target Application this theme can install into,
         with minimum and maximum supported versions. -->
     <em:targetApplication>
       <Description>
         <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
         <em:minVersion>@MOZ_APP_VERSION@</em:minVersion>
         <em:maxVersion>@MOZ_APP_MAXVERSION@</em:maxVersion>
       </Description>
     </em:targetApplication>