Bug 1550403 - Drop call to Servo_Property_IsAnimatable in SMILCSSProperty::IsPropertyAnimatable; r=hiro
authorBrian Birtles <birtles@gmail.com>
Thu, 09 May 2019 06:42:17 +0000
changeset 531997 9f6e01596b42c2a9648dd4a74f8c0956724ebe6a
parent 531996 d5a1d15601fee97edc3a13598bfd16b47759fbb8
child 531998 395d80953041add27448419fd58a0682b2795455
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewershiro
bugs1550403, 1353918
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1550403 - Drop call to Servo_Property_IsAnimatable in SMILCSSProperty::IsPropertyAnimatable; r=hiro As per bug 1353918 comment 13, all these properties are animatable on the Servo side so we no longer need this check. Differential Revision: https://phabricator.services.mozilla.com/D30458
dom/smil/SMILCSSProperty.cpp
dom/smil/SMILCSSProperty.h
--- a/dom/smil/SMILCSSProperty.cpp
+++ b/dom/smil/SMILCSSProperty.cpp
@@ -102,21 +102,16 @@ void SMILCSSProperty::ClearAnimValue() {
   // Put empty string in override style for our property
   mElement->SMILOverrideStyle()->SetPropertyValue(mPropID, EmptyString(),
                                                   nullptr);
 }
 
 // Based on http://www.w3.org/TR/SVG/propidx.html
 // static
 bool SMILCSSProperty::IsPropertyAnimatable(nsCSSPropertyID aPropID) {
-  // Bug 1353918: Drop this check
-  if (!Servo_Property_IsAnimatable(aPropID)) {
-    return false;
-  }
-
   // NOTE: Right now, Gecko doesn't recognize the following properties from
   // the SVG Property Index:
   //   alignment-baseline
   //   baseline-shift
   //   color-profile
   //   color-rendering
   //   glyph-orientation-horizontal
   //   glyph-orientation-vertical
--- a/dom/smil/SMILCSSProperty.h
+++ b/dom/smil/SMILCSSProperty.h
@@ -48,19 +48,16 @@ class SMILCSSProperty : public SMILAttr 
   virtual nsresult SetAnimValue(const SMILValue& aValue) override;
   virtual void ClearAnimValue() override;
 
   /**
    * Utility method - returns true if the given property is supported for
    * SMIL animation.
    *
    * @param   aProperty  The property to check for animation support.
-   * @param   aBackend   The style backend to check for animation support.
-   *                     This is a temporary measure until the Servo backend
-   *                     supports all animatable properties (bug 1353918).
    * @return  true if the given property is supported for SMIL animation, or
    *          false otherwise
    */
   static bool IsPropertyAnimatable(nsCSSPropertyID aPropID);
 
  protected:
   nsCSSPropertyID mPropID;
   // Using non-refcounted pointer for mElement -- we know mElement will stay