Bug 1249818 - Remove clip-path from background tabs. r=gijs a=gchang
authorDão Gottwald <dao@mozilla.com>
Wed, 06 Jul 2016 12:24:04 +0200
changeset 339900 9f0d18b6adc500a1fdfffd986f6a5c7d4af5fcaf
parent 339899 8e3b5b3c31e5fffedaa5bc253222a6ca567bf421
child 339901 11c6cfe72f401b89242a92b9def96768f01b4dc3
push id6249
push userjlund@mozilla.com
push dateMon, 01 Aug 2016 13:59:36 +0000
treeherdermozilla-beta@bad9d4f5bf7e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgijs, gchang
bugs1249818
milestone49.0a2
Bug 1249818 - Remove clip-path from background tabs. r=gijs a=gchang
browser/base/content/tab-shape.inc.svg
browser/themes/osx/browser.css
browser/themes/osx/tabbrowser/tab-selected-end-yosemite-inactive.svg
browser/themes/osx/tabbrowser/tab-selected-start-yosemite-inactive.svg
browser/themes/windows/browser.css
--- a/browser/base/content/tab-shape.inc.svg
+++ b/browser/base/content/tab-shape.inc.svg
@@ -4,12 +4,8 @@
 
 <svg:clipPath id="tab-curve-clip-path-start" clipPathUnits="objectBoundingBox">
   <svg:path d="m 1,0.0625 0.05,0 0,0.938 -1,0 0,-0.028 C 0.32082458,0.95840561 0.4353096,0.81970962 0.48499998,0.5625 0.51819998,0.3905 0.535,0.0659 1,0.0625 z"/>
 </svg:clipPath>
 
 <svg:clipPath id="tab-curve-clip-path-end" clipPathUnits="objectBoundingBox">
   <svg:path d="m 0,0.0625 -0.05,0 0,0.938 1,0 0,-0.028 C 0.67917542,0.95840561 0.56569036,0.81970962 0.51599998,0.5625 0.48279998,0.3905 0.465,0.0659 0,0.0625 z"/>
 </svg:clipPath>
-
-<svg:clipPath id="tab-hover-clip-path" clipPathUnits="objectBoundingBox">
-  <svg:path d="M 0,0.2 0,1 1,1, 1,0.2 z"/>
-</svg:clipPath>
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -2620,26 +2620,16 @@ toolbarbutton.chevron > .toolbarbutton-m
 #tabbrowser-tabs {
   -moz-box-align: stretch;
 }
 
 .tabs-newtab-button > .toolbarbutton-icon {
   padding: 6px 0 4px;
 }
 
-/* Background tabs:
- *
- * Decrease the height of the hoverable region of background tabs whenever the tabs are at the top
- * of the window (e.g. no menubar, tabs in titlebar, etc.) to make it easier to drag the window by
- * the titlebar. We don't need this in fullscreen since window dragging is not an issue there.
- */
-#main-window[tabsintitlebar]:not([inFullscreen]) .tab-background-middle:not([visuallyselected=true]) {
-  clip-path: url(chrome://browser/content/browser.xul#tab-hover-clip-path);
-}
-
 /**
  * Tab Drag and Drop
  */
 
 .tab-drop-indicator {
   list-style-image: url(chrome://browser/skin/tabbrowser/tabDragIndicator.png);
   margin-top: -2px;
   z-index: 3;
--- a/browser/themes/osx/tabbrowser/tab-selected-end-yosemite-inactive.svg
+++ b/browser/themes/osx/tabbrowser/tab-selected-end-yosemite-inactive.svg
@@ -11,18 +11,14 @@
         height: 100%;
         width: 100%;
       }
     </style>
 
     <clipPath id="tab-curve-clip-path-end" clipPathUnits="objectBoundingBox">
       <path d="m 0,0.0625 -0.05,0 0,0.938 1,0 0,-0.028 C 0.67917542,0.95840561 0.56569036,0.81970962 0.51599998,0.5625 0.48279998,0.3905 0.465,0.0659 0,0.0625 z"/>
     </clipPath>
-
-    <clipPath id="tab-hover-clip-path" clipPathUnits="objectBoundingBox">
-      <path d="M 0,0.2 0,1 1,1, 1,0.2 z"/>
-    </clipPath>
   </defs>
 
   <foreignObject width="30" height="31" clip-path="url(#tab-curve-clip-path-end)">
     <div id="tab-background-fill" xmlns="http://www.w3.org/1999/xhtml"></div>
   </foreignObject>
 </svg>
--- a/browser/themes/osx/tabbrowser/tab-selected-start-yosemite-inactive.svg
+++ b/browser/themes/osx/tabbrowser/tab-selected-start-yosemite-inactive.svg
@@ -11,18 +11,14 @@
         height: 100%;
         width: 100%;
       }
     </style>
 
     <clipPath id="tab-curve-clip-path-start" clipPathUnits="objectBoundingBox">
       <path d="m 1,0.0625 0.05,0 0,0.938 -1,0 0,-0.028 C 0.32082458,0.95840561 0.4353096,0.81970962 0.48499998,0.5625 0.51819998,0.3905 0.535,0.0659 1,0.0625 z"/>
     </clipPath>
-
-    <clipPath id="tab-hover-clip-path" clipPathUnits="objectBoundingBox">
-      <path d="M 0,0.2 0,1 1,1, 1,0.2 z"/>
-    </clipPath>
   </defs>
 
   <foreignObject width="30" height="31" clip-path="url(#tab-curve-clip-path-start)">
     <div id="tab-background-fill" xmlns="http://www.w3.org/1999/xhtml"></div>
   </foreignObject>
 </svg>
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -2000,26 +2000,16 @@ html|span.ac-emphasize-text-url {
 }
 
 /* tabbrowser-tab focus ring */
 .tabbrowser-tab:focus > .tab-stack > .tab-content {
   outline: 1px dotted;
   outline-offset: -6px;
 }
 
-/* Background tabs:
- *
- * Decrease the height of the hoverable region of background tabs whenever the tabs are at the top
- * of the window (e.g. no menubar, tabs in titlebar, etc.) to make it easier to drag the window by
- * the titlebar. We don't need this in fullscreen since window dragging is not an issue there.
- */
-#main-window[tabsintitlebar][sizemode=normal] #toolbar-menubar[autohide="true"][inactive] + #TabsToolbar .tab-background-middle:not([visuallyselected=true]) {
-  clip-path: url(chrome://browser/content/browser.xul#tab-hover-clip-path);
-}
-
 /* Tab DnD indicator */
 .tab-drop-indicator {
   list-style-image: url(chrome://browser/skin/tabbrowser/tabDragIndicator.png);
   margin-bottom: -9px;
   z-index: 3;
 }
 
 /* Tab close button */