bug 1523104: remote: remove unused informative remote.httpd.* preferences; r=ato
authorAlexandre Poirot <poirot.alex@gmail.com>
Mon, 04 Mar 2019 09:54:51 -0800
changeset 521116 9f03512232fb
parent 521115 6a8bdb28bc82
child 521117 10dc88c2cacb
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersato
bugs1523104
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1523104: remote: remove unused informative remote.httpd.* preferences; r=ato
remote/RemoteAgent.js
remote/doc/Prefs.md
--- a/remote/RemoteAgent.js
+++ b/remote/RemoteAgent.js
@@ -20,20 +20,16 @@ XPCOMUtils.defineLazyModuleGetters(this,
   Target: "chrome://remote/content/Target.jsm",
   Targets: "chrome://remote/content/Targets.jsm",
   TargetListHandler: "chrome://remote/content/Handler.jsm",
 });
 XPCOMUtils.defineLazyGetter(this, "log", Log.get);
 
 const ENABLED = "remote.enabled";
 const FORCE_LOCAL = "remote.force-local";
-const HTTPD = "remote.httpd";
-const SCHEME = `${HTTPD}.scheme`;
-const HOST = `${HTTPD}.host`;
-const PORT = `${HTTPD}.port`;
 
 const DEFAULT_HOST = "localhost";
 const DEFAULT_PORT = 9222;
 const LOOPBACKS = ["localhost", "127.0.0.1", "[::1]"];
 
 class ParentRemoteAgent {
   constructor() {
     this.server = null;
@@ -80,27 +76,23 @@ class ParentRemoteAgent {
     try {
       this.server._start(port, host);
       log.info(`Remote debugging agent listening on ${this.scheme}://${this.host}:${this.port}/`);
     } catch (e) {
       throw new Error(`Unable to start agent on ${port}: ${e.message}`, e);
     }
 
     Preferences.set(RecommendedPreferences);
-    Preferences.set(SCHEME, this.scheme);
-    Preferences.set(HOST, this.host);
-    Preferences.set(PORT, this.port);
   }
 
   async close() {
     if (this.listening) {
       try {
         await this.server.stop();
 
-        Preferences.resetBranch(HTTPD);
         Preferences.reset(Object.keys(RecommendedPreferences));
 
         this.tabs.stop();
         this.targets.clear();
       } catch (e) {
         throw new Error(`Unable to stop agent: ${e.message}`, e);
       }
 
--- a/remote/doc/Prefs.md
+++ b/remote/doc/Prefs.md
@@ -19,33 +19,8 @@ Limits the remote agent to be allowed to
 e.g. 127.0.0.1, localhost, and ::1.
 
 ### `remote.log.level`
 
 Defines the verbosity of the internal logger.  Available levels
 are, in descending order of severity, `Trace`, `Debug`, `Config`,
 `Info`, `Warn`, `Error`, and `Fatal`.  Note that the value is
 treated case-sensitively.
-
-
-Informative preferences
------------------------
-
-The following preferences are set when the remote agent starts the
-HTTPD frontend:
-
-### `remote.httpd.scheme`
-
-Scheme the server is listening on, e.g. `httpd`.
-
-### `remote.httpd.host`
-
-Hostname the server is bound to.
-
-### `remote.httpd.port`
-
-The port bound by the server.  When starting Firefox with
-`--remote-debugger` you can ask the remote agent to listen on port
-0 to have the system atomically allocate a free port.  You can then
-later check this preference to find out on what port it is listening:
-
-	./firefox --remote-debugger :0
-	1548002326113	RemoteAgent	INFO	Remote debugging agent listening on http://localhost:16738/