Bug 1587989 [wpt PR 19634] - Enable Scroll To Text by default, a=testonly
authorBlink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Tue, 21 Jan 2020 10:55:06 +0000
changeset 573941 9e159341d88b20b90c6b04f92d3412a8591a0336
parent 573940 7ca6056156b6166d7058e4edc6f0412e4f78a58a
child 573942 ae92caa7868148247b965667629072b95705849f
push id12662
push userffxbld-merge
push dateMon, 10 Feb 2020 10:43:10 +0000
treeherdermozilla-beta@ace4081e8200 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1587989, 19634, 1042311, 919204, 1838701, 732592
milestone74.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1587989 [wpt PR 19634] - Enable Scroll To Text by default, a=testonly Automatic update from web-platform-tests Enable Scroll To Text by default (#19634) Enables scroll to text by default for M81. Note we plan to launch via Finch for M80. Intent to ship with LGTMs: https://groups.google.com/a/chromium.org/d/msg/blink-dev/zlLSxQ9BA8Y/t-_3pAiSAwAJ This patch also updates web platform test expectations: - scroll-to-text-fragment.html now passes; it just needed an extra rAF for the fallback to element anchor behavior. - scroll-to-text-fragment-security.html has two expected failures, as they need to be updated to test cross-origin navigations. I'll make this change in a follow-up patch to close bug 1042311. Bug: 919204 Change-Id: Ic2d563934cd9406fb335904a94c390bba789e0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838701 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#732592} Co-authored-by: Nick Burris <nburris@chromium.org> -- wpt-commits: 91ae81eb86ffffeed3abee0f45ccfcd3f82750ef wpt-pr: 19634
testing/web-platform/tests/scroll-to-text-fragment/scroll-to-text-fragment-target.html
--- a/testing/web-platform/tests/scroll-to-text-fragment/scroll-to-text-fragment-target.html
+++ b/testing/web-platform/tests/scroll-to-text-fragment/scroll-to-text-fragment-target.html
@@ -43,33 +43,41 @@ function checkScroll() {
     scrollPosition: position,
     href: window.location.href,
     target: target ? target.id : 'undefined'
   };
 
   let key = (new URL(document.location)).searchParams.get("key");
   stashResults(key, results);
 }
+
+// Ensure two animation frames on load to test the fallback to element anchor,
+// which gets queued for the next frame if the text fragment is not found.
+window.onload = function() {
+  window.requestAnimationFrame(function() {
+    window.requestAnimationFrame(checkScroll);
+  })
+}
 </script>
 <style>
   .scroll-section {
     /* 1000px margin on top and bottom so only one section can be in view. */
     margin: 1000px 0px;
   }
   #hidden {
     visibility: hidden;
   }
   #horizontal-scroll {
     margin-left: 2000px;
   }
   #display-none {
     display: none;
   }
 </style>
-<body onload="window.requestAnimationFrame(checkScroll)">
+<body>
   <div id="element" class="scroll-section">Element</div>
   <p id="text" class="scroll-section">This is a test page !$'()*+./:;=?@_~ &,- &#x30cd;&#x30b3;</p>
   <p id="more-text" class="scroll-section">More test page text</p>
   <div class="scroll-section">
     <div>
       <p>prefix</p>
       <p id="cross-node-context">test page</p>
     </div>