Bug 746816 - Crash closing a select dialog while panning. r=mfinkle a=blocking-fennec
authorWes Johnston <wjohnston@mozilla.com>
Wed, 18 Apr 2012 17:41:12 -0700
changeset 95257 9c94f2cf3f602260c6bf513d162cd7bae249d4a4
parent 95256 19f452f791987d0e7e5dfc0c01d42d2cabea8d8f
child 95258 a975f9c7d7f0c98eb3d79df028ebad34d9ed4ba9
push id886
push userlsblakk@mozilla.com
push dateMon, 04 Jun 2012 19:57:52 +0000
treeherdermozilla-beta@bbd8d5efd6d1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmfinkle, blocking-fennec
bugs746816
milestone14.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 746816 - Crash closing a select dialog while panning. r=mfinkle a=blocking-fennec
mobile/android/base/PromptService.java
--- a/mobile/android/base/PromptService.java
+++ b/mobile/android/base/PromptService.java
@@ -518,17 +518,17 @@ public class PromptService implements On
             // follow this rule so we have to resize them.
             Bitmap bitmap = ((BitmapDrawable) item.icon).getBitmap();
             Drawable d = new BitmapDrawable(Bitmap.createScaledBitmap(bitmap, mIconSize, mIconSize, true));
 
             t.setCompoundDrawablesWithIntrinsicBounds(d, null, null, null);
         }
 
         private void maybeUpdateCheckedState(int position, PromptListItem item, ViewHolder viewHolder) {
-            if (item.isGroup)
+            if (item.isGroup || mSelected == null)
                 return;
 
             CheckedTextView ct;
             try {
                 ct = (CheckedTextView) viewHolder.textView;
             } catch (Exception e) {
                 return;
             }