Bug 1449105 [wpt PR 10191] - [css-typed-om] Stub list-valued tests., a=testonly
authorDarren Shen <shend@chromium.org>
Mon, 09 Apr 2018 18:21:23 +0000
changeset 467203 9b3559817a30c0b0f29d919b5ec8c145d4adfcdb
parent 467202 47729ad34d0c910d0f3a878876cb96f582b4bd57
child 467204 2d92f37b4443fac2124163799a2cb0c9f1835f95
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1449105, 10191, 774887, 981956, 546067
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1449105 [wpt PR 10191] - [css-typed-om] Stub list-valued tests., a=testonly Automatic update from web-platform-tests[css-typed-om] Stub list-valued tests. Currently we're just adding a TODO when we want to test a list-valued property. It's probably easier if we stub that test function and then implement it later. Bug: 774887 Change-Id: Iab3cea915afbcc8490cacbd45e5632a18e7dece1 Reviewed-on: https://chromium-review.googlesource.com/981956 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#546067} wpt-commits: 97d4646fd82ae91238bf0c8bb8f941a0db10ecfb wpt-pr: 10191 wpt-commits: 97d4646fd82ae91238bf0c8bb8f941a0db10ecfb wpt-pr: 10191
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/animation-direction.html
testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/background-image.html
testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/mask-image.html
testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js
testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/transition-duration.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -523535,29 +523535,29 @@
    "1b826ba2a6186ff317e8daa8f604f130be577d3d",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/inline/set.tentative.html": [
    "65c9c20da930fd46136d4dd5706524ae05118807",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/animation-direction.html": [
-   "05e0be2c67fd695d693f2a639acf88ff78d8fd04",
+   "6c988281b4773fa25ef0d811ff6e0cd37a1e0fae",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/backface-visibility.html": [
    "d880e41674d468fe364c74941a8ae0921b9bdfac",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/background-color.html": [
    "f52a2182afc7107a9f411a27aab81c4c4c90ef1e",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/background-image.html": [
-   "1255fea8e74561e14720ccf422fd841e1d3e32fa",
+   "08055b88eca1f841f3b8a9867d8ffeb93d214d1f",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/background.html": [
    "32d684e452a4bafd7b58a0b33d42d32aa51ac091",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/block-size.html": [
    "4dc26a97d56a24c053efac27b5988456d750d186",
@@ -523771,17 +523771,17 @@
    "d1644d7633a8fa097caa5d52f81a84c5cd62f9d0",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/margin.html": [
    "268e2a2844439f1175199034d89d60a56e0e11fd",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/mask-image.html": [
-   "2a20c6818e9d71adbf3902fde74cb26136917e72",
+   "8400ca1a6caf399c5914df06028d6616fb9f9571",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/mix-blend-mode.html": [
    "43a29c4680d0f93c586f3e7d772fe64a56947d87",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/object-fit.html": [
    "9e16a0dac44abcdb6b17475c429694ec78c5ae0a",
@@ -523851,17 +523851,17 @@
    "ae21056fb993efb7112e0bc42fe1269f6bc0c72e",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/resize.html": [
    "533f287facbc82118469f75f9f88a1372848d3b2",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js": [
-   "7e6c530cf36cce5d7b8d02abbbefbdd4370d1be1",
+   "ca6f58ecbab01ee294f4388b456b3b1bdd7a4629",
    "support"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/right.html": [
    "68a2611eaf9eecb7393c2b0db0f4378ebe285f22",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/scroll-margin.html": [
    "7d4636be3e35639b915917412465b443241e95b1",
@@ -523931,17 +523931,17 @@
    "85cbf6daa2686a518566e4ccbfc2ba39197b190e",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/transform.html": [
    "2723b6d3e9a213a1b33e9ecfafd5fd42eb8bca33",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/transition-duration.html": [
-   "b735f3ff6dba561cf2e35a8a85a8e2b93c0edc61",
+   "fe613a427b8c057fb859eb70a58d506c6a0b3cde",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/unicode-bidi.html": [
    "b676714807b4fcdfd5ba7555f7c2ee3d1d9590d2",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/vertical-align.html": [
    "41ae6fd66b5a0e6f3b5f154d839362a4921712cc",
--- a/testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/animation-direction.html
+++ b/testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/animation-direction.html
@@ -8,17 +8,16 @@
 <script src="/resources/testharnessreport.js"></script>
 <script src="../../resources/testhelper.js"></script>
 <script src="resources/testsuite.js"></script>
 <body>
 <div id="log"></div>
 <script>
 'use strict';
 
-// FIXME: animation-direction is list-valued. Run list-valued tests here too.
-runPropertyTests('animation-direction', [
+runListValuedPropertyTests('animation-direction', [
   { syntax: 'normal' },
   { syntax: 'reverse' },
   { syntax: 'alternate-reverse' },
   { syntax: 'alternate' },
 ]);
 
 </script>
--- a/testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/background-image.html
+++ b/testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/background-image.html
@@ -8,15 +8,14 @@
 <script src="/resources/testharnessreport.js"></script>
 <script src="../../resources/testhelper.js"></script>
 <script src="resources/testsuite.js"></script>
 <body>
 <div id="log"></div>
 <script>
 'use strict';
 
-// FIXME: background-image is list-valued. Run list-valued tests here too.
-runPropertyTests('background-image', [
+runListValuedPropertyTests('background-image', [
   { syntax: 'none' },
   { syntax: '<image>' },
 ]);
 
 </script>
--- a/testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/mask-image.html
+++ b/testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/mask-image.html
@@ -8,15 +8,14 @@
 <script src="/resources/testharnessreport.js"></script>
 <script src="../../resources/testhelper.js"></script>
 <script src="resources/testsuite.js"></script>
 <body>
 <div id="log"></div>
 <script>
 'use strict';
 
-// FIXME: mask-image is list-valued. Run list-valued tests here too.
-runPropertyTests('mask-image', [
+runListValuedPropertyTests('mask-image', [
   { syntax: 'none' },
   { syntax: '<image>' },
 ]);
 
 </script>
--- a/testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js
+++ b/testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js
@@ -373,16 +373,22 @@ function runPropertyTests(propertyName, 
     if (!syntaxTested.has(syntax)) {
       testPropertyInvalid(propertyName,
         syntaxExamples.examples,
         syntaxExamples.description);
     }
   }
 }
 
+// Same as runPropertyTests but for list-valued properties.
+function runListValuedPropertyTests(propertyName, testCases) {
+  // TODO(https://crbug.com/545318): Run list-valued tests as well.
+  runPropertyTests(propertyName, testCases);
+}
+
 // Check that |propertyName| doesn't "support" examples in |testExamples|.
 // |testExamples| is a list of CSS string values. An "unsupported" value
 // doesn't have a corresponding Typed OM representation. It normalizes as
 // the base CSSStyleValue.
 function runUnsupportedPropertyTests(propertyName, testExamples) {
   for (const cssText of testExamples) {
     testUnsupportedValue(propertyName, cssText);
   }
--- a/testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/transition-duration.html
+++ b/testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/transition-duration.html
@@ -7,14 +7,13 @@
 <script src="/resources/testharnessreport.js"></script>
 <script src="../../resources/testhelper.js"></script>
 <script src="resources/testsuite.js"></script>
 <body>
 <div id="log"></div>
 <script>
 'use strict';
 
-// FIXME: transition-duration is list-valued. Run list-valued tests here too.
-runPropertyTests('transition-duration', [
+runListValuedPropertyTests('transition-duration', [
   { syntax: '<time>' },
 ]);
 
 </script>