Bug 1130203 - Remove dividers in share overlay. r=mhaigh a=sylvestre
authorMichael Comella <michael.l.comella@gmail.com>
Thu, 26 Feb 2015 18:35:56 -0800
changeset 258338 9a5a28809525
parent 258337 8002be97de82
child 258339 feb7a6808bfb
push id4648
push usermichael.l.comella@gmail.com
push date2015-04-08 16:26 +0000
treeherdermozilla-beta@e399294c9df3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmhaigh, sylvestre
bugs1130203
milestone38.0
Bug 1130203 - Remove dividers in share overlay. r=mhaigh a=sylvestre
mobile/android/base/resources/layout/overlay_share_dialog.xml
--- a/mobile/android/base/resources/layout/overlay_share_dialog.xml
+++ b/mobile/android/base/resources/layout/overlay_share_dialog.xml
@@ -42,43 +42,29 @@
         <!-- Buttons -->
         <LinearLayout
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:layout_marginTop="20dp"
             android:background="@color/overlay_share_background"
             android:orientation="vertical">
 
-            <!-- TODO: Once API 11 is available, stick "showDividers=middle" into the parent and get rid
-                       of these evil separator views. -->
-
             <!-- "Send to Firefox Sync" -->
             <org.mozilla.gecko.overlays.ui.SendTabList
                 style="@style/ShareOverlayButton"
                 android:id="@+id/overlay_send_tab_btn"
-                android:padding="0dp"/>
-
-            <!-- Evil separator -->
-            <View
-                android:layout_width="match_parent"
-                android:layout_height="1dp"
-                android:background="@color/background_light"/>
+                android:padding="0dp"
+                android:divider="@null"/>
 
             <!-- "Add to reading list" -->
             <org.mozilla.gecko.overlays.ui.OverlayDialogButton
                 style="@style/ShareOverlayButton.Text.Container"
                 android:id="@+id/overlay_share_reading_list_btn"
                 android:enabled="false"/>
 
-            <!-- Evil separator -->
-            <View
-                android:layout_width="match_parent"
-                android:layout_height="1dp"
-                android:background="@color/background_light"/>
-
             <!-- "Add bookmark" -->
             <org.mozilla.gecko.overlays.ui.OverlayDialogButton
                 style="@style/ShareOverlayButton.Text.Container"
                 android:id="@+id/overlay_share_bookmark_btn"
                 android:enabled="false"/>
 
         </LinearLayout>
     </LinearLayout>