Bug 1520369 - Don't remove --srcdir from subconfigure command line. r=froydnj
authorMike Hommey <mh+mozilla@glandium.org>
Wed, 16 Jan 2019 15:24:27 +0000
changeset 511286 99c3cc0b39bd4228ed17ddde529d4712214b808b
parent 511285 eda1a7d5a7e928f96cad47cbd904e222f617069a
child 511287 ba1ee17a47e9b8197523fd7d2e3f24734bae80a3
push id10547
push userffxbld-merge
push dateMon, 21 Jan 2019 13:03:58 +0000
treeherdermozilla-beta@24ec1916bffe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1520369
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1520369 - Don't remove --srcdir from subconfigure command line. r=froydnj It was manually removed because autoconf's AC_OUTPUT_SUBDIRS passes it, but we've not been using AC_OUTPUT_SUBDIRS for a while. Depends on D16637 Differential Revision: https://phabricator.services.mozilla.com/D16638
build/subconfigure.py
--- a/build/subconfigure.py
+++ b/build/subconfigure.py
@@ -16,21 +16,16 @@ import mozpack.path as mozpath
 
 
 CONFIGURE_DATA = 'configure.pkl'
 
 
 def prepare(srcdir, objdir, args):
     parser = argparse.ArgumentParser()
     parser.add_argument('--cache-file', type=str)
-    # The --srcdir argument is simply ignored. It's a useless autoconf feature
-    # that we don't support well anyways. This makes it stripped from `others`
-    # and allows to skip setting it when calling the subconfigure (configure
-    # will take it from the configure path anyways).
-    parser.add_argument('--srcdir', type=str)
 
     data_file = os.path.join(objdir, CONFIGURE_DATA)
     previous_args = None
     if os.path.exists(data_file):
         with open(data_file, 'rb') as f:
             data = pickle.load(f)
             previous_args = data['args']