Backed out changeset 0564666f34b2 (bug 1507674) for crashtests in reftest/tests/dom/base/crashtests/1397795.html CLOSED TREE
authorMargareta Eliza Balazs <ebalazs@mozilla.com>
Fri, 21 Dec 2018 12:58:34 +0200
changeset 508760 997e573df3677442ab25da9f7f6508bcae8b070e
parent 508759 4389ed44ce098d81136244e70a941d812ea73221
child 508761 2eab9d9bd89ecf6f26887f01c6df632ac1a255af
push id10547
push userffxbld-merge
push dateMon, 21 Jan 2019 13:03:58 +0000
treeherdermozilla-beta@24ec1916bffe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1507674, 1397795
milestone66.0a1
backs out0564666f34b28960ab4e1a4e2ba6b62c74e542ca
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 0564666f34b2 (bug 1507674) for crashtests in reftest/tests/dom/base/crashtests/1397795.html CLOSED TREE
layout/base/RestyleManager.cpp
layout/style/crashtests/1507674.html
layout/style/crashtests/crashtests.list
--- a/layout/base/RestyleManager.cpp
+++ b/layout/base/RestyleManager.cpp
@@ -1733,17 +1733,16 @@ void RestyleManager::ProcessRestyledFram
       }
       if (hint & nsChangeHint_VisibilityChange) {
         frame->UpdateVisibleDescendantsState();
       }
     }
   }
 
   aChangeList.Clear();
-  FlushOverflowChangedTracker();
 }
 
 /* static */ uint64_t RestyleManager::GetAnimationGenerationForFrame(
     nsIFrame* aFrame) {
   EffectSet* effectSet = EffectSet::GetEffectSet(aFrame);
   return effectSet ? effectSet->GetAnimationGeneration() : 0;
 }
 
@@ -3001,16 +3000,18 @@ void RestyleManager::DoProcessPendingRes
       // In any case, we don't need to increment the restyle generation in that
       // case.
       IncrementRestyleGeneration();
     }
   }
 
   doc->ClearServoRestyleRoot();
 
+  FlushOverflowChangedTracker();
+
   ClearSnapshots();
   styleSet->AssertTreeIsClean();
   mHaveNonAnimationRestyles = false;
   mRestyleForCSSRuleChanges = false;
   mInStyleRefresh = false;
 
   // Now that everything has settled, see if we have enough free rule nodes in
   // the tree to warrant sweeping them.
deleted file mode 100644
--- a/layout/style/crashtests/1507674.html
+++ /dev/null
@@ -1,16 +0,0 @@
-<style>
-menuitem { -webkit-filter: url(#a) }
-</style>
-<menuitem>A
-</menu>
-<svg id="b" style="-webkit-text-stroke-width: 1px;">
-<text id="a">
-<menu style="background-image: url();">
-<menuitem id="c">
-<script>
-c.offsetTop;
-a.setAttribute("exponent", "1");
-c.offsetTop;
-b.setAttribute("text-decoration", "line-through");
-c.offsetTop;
-</script>
--- a/layout/style/crashtests/crashtests.list
+++ b/layout/style/crashtests/crashtests.list
@@ -290,11 +290,10 @@ load 1457288.html
 load 1457985.html
 load 1468640.html
 load 1469076.html
 load 1475003.html
 load 1479681.html
 load 1488817.html
 load 1490012.html
 load 1502893.html
-load 1507674.html
 load 1509989.html
 load 1514086.html