Bug 1101704 - Use non-iterable object in browser_console_addonsdk_loader_exception.js. m=msucan
authorTooru Fujisawa <arai_a@mac.com>
Sat, 29 Nov 2014 14:04:25 +0900
changeset 243914 9902a6ce983179a15a06f69573465c45b34e9168
parent 243913 6d64e1e46eb1efeb6e5a5bb39936d4c713f1820f
child 243915 084bba95469cd9b3e57bc365a5d337e0273b35cc
push id4489
push userraliiev@mozilla.com
push dateMon, 23 Feb 2015 15:17:55 +0000
treeherdermozilla-beta@fd7c3dc24146 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1101704
milestone37.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1101704 - Use non-iterable object in browser_console_addonsdk_loader_exception.js. m=msucan
browser/devtools/webconsole/test/browser_console_addonsdk_loader_exception.js
--- a/browser/devtools/webconsole/test/browser_console_addonsdk_loader_exception.js
+++ b/browser/devtools/webconsole/test/browser_console_addonsdk_loader_exception.js
@@ -23,34 +23,34 @@ function test()
     ok(webconsole, "web console opened");
 
     browserconsole = yield HUDService.toggleBrowserConsole();
     ok(browserconsole, "browser console opened");
 
     // Cause an exception in a script loaded with the addon-sdk loader.
     let toolbox = gDevTools.getToolbox(webconsole.target);
     let oldPanels = toolbox._toolPanels;
-    toolbox._toolPanels = null;
+    toolbox._toolPanels = {}; // non-iterable
 
     function fixToolbox() {
       toolbox._toolPanels = oldPanels;
     }
 
     info("generate exception and wait for message");
 
     executeSoon(() => {
       executeSoon(fixToolbox);
       expectUncaughtException();
       toolbox.getToolPanels();
     });
 
     let [result] = yield waitForMessages({
       webconsole: browserconsole,
       messages: [{
-        text: "TypeError: can't convert null to object",
+        text: "TypeError: this._toolPanels is not iterable",
         category: CATEGORY_JS,
         severity: SEVERITY_ERROR,
       }],
     });
 
     fixToolbox();
 
     let msg = [...result.matched][0];