Bug 1351117 Part 1: Change an assert on nsLayoutStylesheetCache::Shutdown into a warning, since it only notes that the cache was never used. r=heycam
authorBrad Werth <bwerth@mozilla.com>
Mon, 05 Jun 2017 13:57:36 -0700
changeset 410643 98b04000fee7944862faa904f8c426fb64c91c21
parent 410642 8a8f6ea6d05652f93cff34147e3934c702a6bade
child 410644 ea5ac39685cd2712a7f48ddca1de10eabb3d8a28
push id7391
push usermtabara@mozilla.com
push dateMon, 12 Jun 2017 13:08:53 +0000
treeherdermozilla-beta@2191d7f87e2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersheycam
bugs1351117
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1351117 Part 1: Change an assert on nsLayoutStylesheetCache::Shutdown into a warning, since it only notes that the cache was never used. r=heycam MozReview-Commit-ID: 5dHMnjE8ufl
layout/style/nsLayoutStylesheetCache.cpp
--- a/layout/style/nsLayoutStylesheetCache.cpp
+++ b/layout/style/nsLayoutStylesheetCache.cpp
@@ -251,20 +251,20 @@ nsLayoutStylesheetCache::DesignModeSheet
   return mDesignModeSheet;
 }
 
 void
 nsLayoutStylesheetCache::Shutdown()
 {
   gCSSLoader_Gecko = nullptr;
   gCSSLoader_Servo = nullptr;
-  MOZ_ASSERT(!gStyleCache_Gecko || !gUserContentSheetURL_Gecko,
-             "Got the URL but never used by Gecko?");
-  MOZ_ASSERT(!gStyleCache_Servo || !gUserContentSheetURL_Servo,
-             "Got the URL but never used by Servo?");
+  NS_WARNING_ASSERTION(!gStyleCache_Gecko || !gUserContentSheetURL_Gecko,
+                       "Got the URL but never used by Gecko?");
+  NS_WARNING_ASSERTION(!gStyleCache_Servo || !gUserContentSheetURL_Servo,
+                       "Got the URL but never used by Servo?");
   gStyleCache_Gecko = nullptr;
   gStyleCache_Servo = nullptr;
   gUserContentSheetURL_Gecko = nullptr;
   gUserContentSheetURL_Servo = nullptr;
 }
 
 void
 nsLayoutStylesheetCache::SetUserContentCSSURL(nsIURI* aURI)