Bug 1278505 - Remove unneeded NS_NOTREACHED from DeallocPPrintProgressDialogChild(). r=mconley, a=sledru
authorTing-Yu Chou <janus926@gmail.com>
Fri, 22 Jul 2016 09:35:22 +0800
changeset 340116 97ebf3a44e2bfd88f2308eba1d4c13fb82811810
parent 340115 385b9ea08ff775aff8a26041a007199dfbe053ac
child 340117 42c3abe40b3bbea3611cde618c150dbff8c68542
push id6249
push userjlund@mozilla.com
push dateMon, 01 Aug 2016 13:59:36 +0000
treeherdermozilla-beta@bad9d4f5bf7e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmconley, sledru
bugs1278505
milestone49.0a2
Bug 1278505 - Remove unneeded NS_NOTREACHED from DeallocPPrintProgressDialogChild(). r=mconley, a=sledru MozReview-Commit-ID: 7WvZM390h8W
embedding/components/printingui/ipc/nsPrintingProxy.cpp
--- a/embedding/components/printingui/ipc/nsPrintingProxy.cpp
+++ b/embedding/components/printingui/ipc/nsPrintingProxy.cpp
@@ -221,21 +221,19 @@ nsPrintingProxy::AllocPPrintProgressDial
   NS_NOTREACHED("Allocator for PPrintProgressDialogChild should not be "
                 "called on nsPrintingProxy.");
   return nullptr;
 }
 
 bool
 nsPrintingProxy::DeallocPPrintProgressDialogChild(PPrintProgressDialogChild* aActor)
 {
-  // The parent process will never initiate the PPrintProgressDialog
-  // protocol connection, so no need to provide an deallocator here.
-  NS_NOTREACHED("Deallocator for PPrintProgressDialogChild should not be "
-                "called on nsPrintingProxy.");
-  return false;
+  // The PrintProgressDialogChild implements refcounting, and
+  // will take itself out.
+  return true;
 }
 
 PPrintSettingsDialogChild*
 nsPrintingProxy::AllocPPrintSettingsDialogChild()
 {
   // The parent process will never initiate the PPrintSettingsDialog
   // protocol connection, so no need to provide an allocator here.
   NS_NOTREACHED("Allocator for PPrintSettingsDialogChild should not be "