Bug 1498381 - EventUtils.js shouldn't dispatch artificial mouseup after dnd, r=masayuki
☠☠ backed out by 4b02380c0bbb ☠ ☠
authorOlli Pettay <Olli.Pettay@helsinki.fi>
Fri, 12 Oct 2018 14:05:26 +0300
changeset 496851 962c7631d98cf3c4a12cdda90fcd70e1f17cb1f8
parent 496850 27ce807450490a5a443c71b3431d5d51c3223ece
child 496852 0178681fab81bb70450098ee50f04ff9c34fc02b
push id9984
push userffxbld-merge
push dateMon, 15 Oct 2018 21:07:35 +0000
treeherdermozilla-beta@183d27ea8570 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmasayuki
bugs1498381
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1498381 - EventUtils.js shouldn't dispatch artificial mouseup after dnd, r=masayuki
testing/mochitest/tests/SimpleTest/EventUtils.js
--- a/testing/mochitest/tests/SimpleTest/EventUtils.js
+++ b/testing/mochitest/tests/SimpleTest/EventUtils.js
@@ -2330,18 +2330,16 @@ function synthesizeDropAfterDragOver(aRe
   if (aResult) {
     effect = "none";
   } else if (effect != "none") {
     event = createDragEventObject("drop", aDestElement, aDestWindow,
                                   aDataTransfer, aDragEvent);
     sendDragEvent(event, aDestElement, aDestWindow);
   }
 
-  synthesizeMouseAtCenter(aDestElement, { type: "mouseup" }, aDestWindow);
-
   return effect;
 }
 
 /**
  * Emulate a drag and drop by emulating a dragstart and firing events dragenter,
  * dragover, and drop.
  *
  * @param aSrcElement   The element to use to start the drag.
@@ -2460,17 +2458,16 @@ async function synthesizePlainDragAndDro
     await new Promise(r => setTimeout(r, 0));
 
     event = createDragEventObject("drop", destElement, destWindow,
                                   dataTransfer, {});
     sendDragEvent(event, destElement, destWindow);
 
     await new Promise(r => setTimeout(r, 0));
 
-    synthesizeMouseAtCenter(destElement, { type: "mouseup" }, destWindow);
   } finally {
     ds.endDragSession(true, 0);
   }
 }
 
 var PluginUtils =
 {
   withTestPlugin : function(callback)