Bug 1369604 - review: rm comment from WONTFIX'd bug. r=mcomella
authorMichael Comella <michael.l.comella@gmail.com>
Fri, 28 Jul 2017 17:58:05 -0700
changeset 420721 95ca4a6f89572763b25a41403861871104af6f44
parent 420720 dd051eb3bbf65a6276b374ce70a523831c1c4628
child 420722 8227a596f3fd5de690caf5e8d66d731b50f1c6ed
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmcomella
bugs1369604
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1369604 - review: rm comment from WONTFIX'd bug. r=mcomella MozReview-Commit-ID: 5zgonuODZHQ
mobile/android/base/java/org/mozilla/gecko/activitystream/ranking/HighlightsRanking.java
--- a/mobile/android/base/java/org/mozilla/gecko/activitystream/ranking/HighlightsRanking.java
+++ b/mobile/android/base/java/org/mozilla/gecko/activitystream/ranking/HighlightsRanking.java
@@ -51,17 +51,16 @@ public class HighlightsRanking {
     private static final int[] HIGHLIGHT_WEIGHT_FEATURES;
     /** The weights for scoring features. */
     private static final HighlightCandidate.Features HIGHLIGHT_WEIGHTS = new HighlightCandidate.Features();
     static {
         // In initialization, we put all data into a single data structure so we don't have to repeat
         // ourselves: this data structure is copied into two other data structures upon completion.
         //
         // To add a weight, just add it to tmpWeights as seen below.
-        // TODO: Needs confirmation from the desktop team that this is the correct weight mapping (Bug 1336037)
         final SparseArray<Double> tmpWeights = new SparseArray<>();
         tmpWeights.put(FEATURE_VISITS_COUNT, -0.1);
         tmpWeights.put(FEATURE_DESCRIPTION_LENGTH, -0.1);
         tmpWeights.put(FEATURE_PATH_LENGTH, -0.1);
 
         tmpWeights.put(FEATURE_QUERY_LENGTH, 0.4);
         tmpWeights.put(FEATURE_IMAGE_SIZE, 0.2);