Bug 1507374 [wpt PR 14063] - [LongTasks] Change TaskAttributionTiming name to 'unknown', a=testonly
☠☠ backed out by 46ad93280b06 ☠ ☠
authorNicolas Pena <npm@chromium.org>
Mon, 19 Nov 2018 18:45:29 +0000
changeset 503728 956ed95b791ee5dbb48bb027943e5257144fb2d7
parent 503727 ac81704153383bad49d9009a5992d97517381424
child 503729 0475d6073c309df4fb00aa1f2adad320d6f0a276
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1507374, 14063, 1336367, 608479
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1507374 [wpt PR 14063] - [LongTasks] Change TaskAttributionTiming name to 'unknown', a=testonly Automatic update from web-platform-tests[LongTasks] Change TaskAttributionTiming name to 'unknown' At TPAC, we agreed that 'script' is confusing because it implies that longtasks only measure script work. Thus, we decided to change the name to 'unknown'. Also see https://github.com/w3c/longtasks/issues/47. Change-Id: I5a0666d0fa078bfeac8ab6e8397b9b51aca3e833 Reviewed-on: https://chromium-review.googlesource.com/c/1336367 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#608479} -- wpt-commits: 4309ceb7b165a42534514ca9933846cc0912bdae wpt-pr: 14063
testing/web-platform/tests/longtask-timing/longtask-attributes.html
testing/web-platform/tests/longtask-timing/longtask-in-childiframe-crossorigin.html
testing/web-platform/tests/longtask-timing/longtask-in-childiframe.html
testing/web-platform/tests/longtask-timing/longtask-in-externalscript.html
testing/web-platform/tests/longtask-timing/longtask-in-parentiframe.html
testing/web-platform/tests/longtask-timing/longtask-in-raf.html
testing/web-platform/tests/longtask-timing/longtask-in-sibling-iframe-crossorigin.html
testing/web-platform/tests/longtask-timing/longtask-in-sibling-iframe.html
--- a/testing/web-platform/tests/longtask-timing/longtask-attributes.html
+++ b/testing/web-platform/tests/longtask-timing/longtask-attributes.html
@@ -27,17 +27,17 @@
             const currentTime = performance.now();
             assert_less_than_equal(longtask.startTime, currentTime);
 
             // Assert the TaskAttributionTiming entry in attribution.
             assert_equals(longtask.attribution.length, 1,
                 'Exactly one attribution entry is expected');
             const attribution = longtask.attribution[0];
             assert_equals(attribution.entryType, 'taskattribution');
-            assert_equals(attribution.name, 'script');
+            assert_equals(attribution.name, 'unknown');
             assert_equals(attribution.duration, 0);
             assert_equals(attribution.startTime, 0);
             assert_equals(attribution.containerId, '');
             assert_equals(attribution.containerName, '');
             assert_equals(attribution.containerSrc, '');
             observer.disconnect();
             t.done();
         })
@@ -47,9 +47,9 @@
     window.onload = () => {
         /* Generate a slow task */
         const begin = window.performance.now();
         while (window.performance.now() < begin + 60);
     };
 }, 'Performance longtask entries are observable.');
 </script>
 
-</body>
\ No newline at end of file
+</body>
--- a/testing/web-platform/tests/longtask-timing/longtask-in-childiframe-crossorigin.html
+++ b/testing/web-platform/tests/longtask-timing/longtask-in-childiframe-crossorigin.html
@@ -28,17 +28,17 @@
             assert_equals(longtask.name, 'cross-origin-descendant');
             assert_greater_than(longtask.duration, 50);
 
             // Assert the TaskAttributionTiming entry in attribution.
             assert_equals(longtask.attribution.length, 1,
                 'Exactly one attribution entry is expected');
             const attribution = longtask.attribution[0];
             assert_equals(attribution.entryType, 'taskattribution');
-            assert_equals(attribution.name, 'script');
+            assert_equals(attribution.name, 'unknown');
             assert_equals(attribution.duration, 0);
             assert_equals(attribution.startTime, 0);
             assert_equals(attribution.containerId, 'child-iframe-id');
             assert_equals(attribution.containerName, 'child-iframe-name');
             assert_equals(attribution.containerSrc,
                 'resources/subframe-with-longtask.html');
             observer.disconnect();
             t.done();
--- a/testing/web-platform/tests/longtask-timing/longtask-in-childiframe.html
+++ b/testing/web-platform/tests/longtask-timing/longtask-in-childiframe.html
@@ -33,17 +33,17 @@
             const currentTime = performance.now();
             assert_less_than_equal(longtask.startTime, currentTime);
 
             // Assert the TaskAttributionTiming entry in attribution.
             assert_equals(longtask.attribution.length, 1,
                 'Exactly one attribution entry is expected');
             const attribution = longtask.attribution[0];
             assert_equals(attribution.entryType, 'taskattribution');
-            assert_equals(attribution.name, 'script');
+            assert_equals(attribution.name, 'unknown');
             assert_equals(attribution.duration, 0);
             assert_equals(attribution.startTime, 0);
             assert_equals(attribution.containerId, 'child-iframe-id');
             assert_equals(attribution.containerName, 'child-iframe-name');
             assert_equals(attribution.containerSrc, 'resources/subframe-with-longtask.html');
             observer.disconnect();
             t.done();
         })
--- a/testing/web-platform/tests/longtask-timing/longtask-in-externalscript.html
+++ b/testing/web-platform/tests/longtask-timing/longtask-in-externalscript.html
@@ -24,17 +24,17 @@
             assert_equals(longtask.name, 'self');
             assert_greater_than(longtask.duration, 50);
 
             // Assert the TaskAttributionTiming entry in attribution.
             assert_equals(longtask.attribution.length, 1,
                 'Exactly one attribution entry is expected');
             const attribution = longtask.attribution[0];
             assert_equals(attribution.entryType, 'taskattribution');
-            assert_equals(attribution.name, 'script');
+            assert_equals(attribution.name, 'unknown');
             assert_equals(attribution.duration, 0);
             assert_equals(attribution.startTime, 0);
             assert_equals(attribution.containerId, '');
             assert_equals(attribution.containerName, '');
             assert_equals(attribution.containerSrc, '');
             observer.disconnect();
             t.done();
         })
@@ -42,9 +42,9 @@
     observer.observe({entryTypes: ['longtask']});
     window.onload = () => {
         const script = document.createElement('script');
         script.src = 'resources/makelongtask.js';
         document.body.appendChild(script);
     }
 }, 'Performance longtask entries are observable.');
 </script>
-</body>
\ No newline at end of file
+</body>
--- a/testing/web-platform/tests/longtask-timing/longtask-in-parentiframe.html
+++ b/testing/web-platform/tests/longtask-timing/longtask-in-parentiframe.html
@@ -10,17 +10,17 @@
   const t = async_test(t => {
     if (typeof PerformanceLongTaskTiming === 'undefined') {
         assert_unreached("Longtasks are not supported.");
         t.done();
     }
     window.addEventListener('message', t.step_func(e => {
       assert_equals(e.data['entryType'], 'longtask');
       assert_equals(e.data['frame-attribution'], 'same-origin-ancestor');
-      assert_equals(e.data['task-attribution'], 'script');
+      assert_equals(e.data['task-attribution'], 'unknown');
       assert_equals(e.data['containerId'], '');
       assert_equals(e.data['containerName'], '');
       assert_equals(e.data['containerSrc'], '');
       t.done();
     }));
   }, 'Performance longtask entries in parent are observable in child iframe.');
 
   const iframe = document.createElement('iframe');
--- a/testing/web-platform/tests/longtask-timing/longtask-in-raf.html
+++ b/testing/web-platform/tests/longtask-timing/longtask-in-raf.html
@@ -24,17 +24,17 @@
             assert_equals(longtask.name, 'self');
             assert_greater_than(longtask.duration, 50);
 
             // Assert the TaskAttributionTiming entry in attribution.
             assert_equals(longtask.attribution.length, 1,
                 'Exactly one attribution entry is expected');
             const attribution = longtask.attribution[0];
             assert_equals(attribution.entryType, 'taskattribution');
-            assert_equals(attribution.name, 'script');
+            assert_equals(attribution.name, 'unknown');
             assert_equals(attribution.duration, 0);
             assert_equals(attribution.startTime, 0);
             assert_equals(attribution.containerId, '');
             assert_equals(attribution.containerName, '');
             assert_equals(attribution.containerSrc, '');
             observer.disconnect();
             t.done();
         })
--- a/testing/web-platform/tests/longtask-timing/longtask-in-sibling-iframe-crossorigin.html
+++ b/testing/web-platform/tests/longtask-timing/longtask-in-sibling-iframe-crossorigin.html
@@ -10,17 +10,17 @@
   async_test(t => {
     if (typeof PerformanceLongTaskTiming === 'undefined') {
         assert_unreached("Longtasks are not supported.");
         t.done();
     }
     window.addEventListener('message', t.step_func(e => {
       assert_equals(e.data['entryType'], 'longtask');
       assert_equals(e.data['frame-attribution'], 'cross-origin-unreachable');
-      assert_equals(e.data['task-attribution'], 'script');
+      assert_equals(e.data['task-attribution'], 'unknown');
       assert_equals(e.data['containerId'], '');
       assert_equals(e.data['containerName'], '');
       assert_equals(e.data['containerSrc'], '');
       t.done();
     }));
     const observingFrame = document.createElement('iframe');
     observingFrame.id = 'observing-iframe-id';
     observingFrame.name = 'observing-iframe-name';
--- a/testing/web-platform/tests/longtask-timing/longtask-in-sibling-iframe.html
+++ b/testing/web-platform/tests/longtask-timing/longtask-in-sibling-iframe.html
@@ -10,17 +10,17 @@
   async_test(t => {
     if (typeof PerformanceLongTaskTiming === 'undefined') {
         assert_unreached("Longtasks are not supported.");
         t.done();
     }
     window.addEventListener('message', t.step_func(e => {
       assert_equals(e.data['entryType'], 'longtask');
       assert_equals(e.data['frame-attribution'], 'same-origin');
-      assert_equals(e.data['task-attribution'], 'script');
+      assert_equals(e.data['task-attribution'], 'unknown');
       assert_equals(e.data['containerId'], 'longtask-iframe-id');
       assert_equals(e.data['containerName'], 'longtask-iframe-name');
       assert_equals(e.data['containerSrc'], 'resources/subframe-with-longtask.html');
       t.done();
     }));
     const observingFrame = document.createElement('iframe');
     observingFrame.id = 'observing-iframe-id';
     observingFrame.name = 'observing-iframe-name';