Bug 1323770 - Marionette should not take screenshots for skipped tests. r=maja_zf a=test-only
authorHenrik Skupin <mail@hskupin.info>
Wed, 21 Dec 2016 15:19:40 +0100
changeset 366118 94b956158413a846c1388816b8b596e22ea1515b
parent 366117 c57768314ac5046680ada6798ce46138c27f115a
child 366119 241de1275fa8e336c3cb4623312e3eaab8f3ce27
push id6795
push userjlund@mozilla.com
push dateMon, 23 Jan 2017 14:19:46 +0000
treeherdermozilla-beta@76101b503191 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmaja_zf, test-only
bugs1323770
milestone52.0a2
Bug 1323770 - Marionette should not take screenshots for skipped tests. r=maja_zf a=test-only Taking screenshots for skipped tests is useless and should be avoided to reduce the size of the test logs. MozReview-Commit-ID: 9HPH7pSXTj9
testing/marionette/harness/marionette_harness/runner/base.py
testing/marionette/harness/requirements.txt
--- a/testing/marionette/harness/marionette_harness/runner/base.py
+++ b/testing/marionette/harness/marionette_harness/runner/base.py
@@ -547,16 +547,20 @@ class BaseMarionetteTestRunner(object):
         self.workspace = workspace
         # If no workspace is set, default location for gecko.log is .
         # and default location for profile is TMP
         self.workspace_path = workspace or os.getcwd()
         self.verbose = verbose
         self.e10s = e10s
 
         def gather_debug(test, status):
+            # No screenshots and page source for skipped tests
+            if status == "SKIP":
+                return
+
             rv = {}
             marionette = test._marionette_weakref()
 
             # In the event we're gathering debug without starting a session,
             # skip marionette commands
             if marionette.session is not None:
                 try:
                     with marionette.using_context(marionette.CONTEXT_CHROME):
--- a/testing/marionette/harness/requirements.txt
+++ b/testing/marionette/harness/requirements.txt
@@ -4,11 +4,11 @@ marionette-driver >= 2.2.0
 mozcrash >= 0.5
 mozdevice >= 0.44
 mozinfo >= 0.8
 mozlog >= 3.0
 moznetwork >= 0.21
 mozprocess >= 0.9
 mozprofile >= 0.7
 mozrunner >= 6.13
-moztest >= 0.7
+moztest >= 0.8
 mozversion >= 1.1
 wptserve >= 1.3.0