Bug 1708534 - Use the specified input colours for dark and light built-in themes. r=jaws a=pascalc
authorMike Conley <mconley@mozilla.com>
Wed, 12 May 2021 20:45:30 +0000
changeset 644609 938e3c0e903891e2a3412bf7152809ee2425d3f4
parent 644608 dc104670e3682cb920113f8ff56eb674dc99a350
child 644610 70492ed78a99c7352d9f5f64787d8b1bc98b901f
push id15469
push userpchevrel@mozilla.com
push dateWed, 19 May 2021 16:46:10 +0000
treeherdermozilla-beta@5b9adbb1aff5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws, pascalc
bugs1708534
milestone89.0
Bug 1708534 - Use the specified input colours for dark and light built-in themes. r=jaws a=pascalc It looks like we erroneously used the placeholder colour for the dark theme input colour. This updates the dark theme to use the correct colour. It also updates the light theme to use the same input colours as defined in the light variation of the system theme. Differential Revision: https://phabricator.services.mozilla.com/D115000
browser/themes/addons/dark/manifest.json
browser/themes/addons/light/manifest.json
toolkit/mozapps/extensions/default-theme/manifest.json
--- a/browser/themes/addons/dark/manifest.json
+++ b/browser/themes/addons/dark/manifest.json
@@ -51,17 +51,17 @@
       "checkbox_unchecked_background_hover": "rgb(82, 82, 94)",
       "checkbox_unchecked_background_active": "rgb(91, 91, 102)",
       "checkbox_checked_background": "rgb(0, 221, 255)",
       "checkbox_checked_color": "rgb(43, 42, 51)",
       "checkbox_checked_background_hover": "rgb(128, 235, 255)",
       "checkbox_checked_background_active": "rgb(170, 242, 255)",
       "error_text_color": "rgb(255, 154, 162)",
       "input_background": "#42414D",
-      "input_color": "#BFBFC9",
+      "input_color": "rgb(251,251,254)",
       "input_border": "#8f8f9d",
       "input_border_error": "rgb(255, 132, 138)",
       "zoom_controls": "rgb(74,74,85)",
       "autocomplete_popup_separator": "rgb(82,82,94)",
       "appmenu_update_icon_color": "#54FFBD",
       "appmenu_warning_icon_color": "#FFBD4F",
       "appmenu_info_icon_color": "#80EBFF",
       "tab_icon_overlay_stroke": "rgb(66,65,77)",
--- a/browser/themes/addons/light/manifest.json
+++ b/browser/themes/addons/light/manifest.json
@@ -49,29 +49,33 @@
       "checkbox_unchecked_background": "rgb(240, 240, 244)",
       "checkbox_unchecked_background_hover": "rgb(224, 224, 230)",
       "checkbox_unchecked_background_active": "rgb(207, 207, 216)",
       "checkbox_checked_background": "rgb(0, 97, 224)",
       "checkbox_checked_background_hover": "rgb(2, 80, 187)",
       "checkbox_checked_background_active": "rgb(5, 62, 148)",
       "checkbox_checked_color": "rgb(251, 251, 254)",
       "error_text_color": "rgb(197,0,66)",
+      "input_color": "rgb(21,20,26)",
+      "input_background": "rgb(255,255,255)",
+      "input_border_error": "#E22850",
       "autocomplete_popup_hover": "rgb(240,240,244)",
       "autocomplete_popup_separator": "rgb(240,240,244)",
       "appmenu_update_icon_color": "#2AC3A2",
       "appmenu_warning_icon_color": "#FFA436",
       "appmenu_info_icon_color": "#0090ED",
       "tab_icon_overlay_stroke": "rgb(255,255,255)",
       "tab_icon_overlay_fill": "rgb(91,91,102)"
     },
     "properties": {
       "panel_hover": "color-mix(in srgb, currentColor 12%, transparent)",
       "panel_active": "color-mix(in srgb, currentColor 20%, transparent)",
       "panel_active_darker": "color-mix(in srgb, currentColor 27%, transparent)",
-      "toolbar_field_icon_opacity": "0.72"
+      "toolbar_field_icon_opacity": "0.72",
+      "input_border_color": "color-mix(in srgb, currentColor 41%, transparent)"
     }
   },
 
   "theme_experiment": {
     "stylesheet": "experiment.css",
     "colors": {
       "popup_action_color": "--urlbar-popup-action-color",
       "button": "--button-bgcolor",
@@ -85,24 +89,29 @@
       "checkbox_unchecked_background": "--checkbox-unchecked-bgcolor",
       "checkbox_unchecked_background_hover": "--checkbox-unchecked-hover-bgcolor",
       "checkbox_unchecked_background_active": "--checkbox-unchecked-active-bgcolor",
       "checkbox_checked_background": "--checkbox-checked-bgcolor",
       "checkbox_checked_background_hover": "--checkbox-checked-hover-bgcolor",
       "checkbox_checked_background_active": "--checkbox-checked-active-bgcolor",
       "checkbox_checked_color": "--checkbox-checked-color",
       "error_text_color": "--error-text-color",
+      "input_background": "--input-bgcolor",
+      "input_color": "--input-color",
+      "input_border": "--input-border-color",
+      "input_border_error": "--input-error-border-color",
       "autocomplete_popup_hover": "--autocomplete-popup-hover-background",
       "autocomplete_popup_separator": "--autocomplete-popup-separator-color",
       "appmenu_update_icon_color": "--panel-banner-item-update-supported-bgcolor",
       "appmenu_warning_icon_color": "--panel-banner-item-warning-icon-bgcolor",
       "appmenu_info_icon_color": "--panel-banner-item-info-icon-bgcolor",
       "tab_icon_overlay_stroke": "--tab-icon-overlay-stroke",
       "tab_icon_overlay_fill": "--tab-icon-overlay-fill"
     },
     "properties": {
       "panel_hover": "--arrowpanel-dimmed",
       "panel_active": "-arrowpanel-dimmed-further",
       "panel_active_darker": "--arrowpanel-dimmed-even-further",
-      "toolbar_field_icon_opacity": "--urlbar-icon-fill-opacity"
+      "toolbar_field_icon_opacity": "--urlbar-icon-fill-opacity",
+      "input_border_color": "--input-border-color"
     }
   }
 }
--- a/toolkit/mozapps/extensions/default-theme/manifest.json
+++ b/toolkit/mozapps/extensions/default-theme/manifest.json
@@ -54,17 +54,17 @@
       "checkbox_unchecked_background_hover": "rgb(82, 82, 94)",
       "checkbox_unchecked_background_active": "rgb(91, 91, 102)",
       "checkbox_checked_background": "rgb(0, 221, 255)",
       "checkbox_checked_color": "rgb(43, 42, 51)",
       "checkbox_checked_background_hover": "rgb(128, 235, 255)",
       "checkbox_checked_background_active": "rgb(170, 242, 255)",
       "error_text_color": "rgb(255, 154, 162)",
       "input_background": "#42414D",
-      "input_color": "#BFBFC9",
+      "input_color": "rgb(251,251,254)",
       "input_border": "#8f8f9d",
       "input_border_error": "rgb(255, 132, 138)",
       "zoom_controls": "rgb(74,74,85)",
       "autocomplete_popup_separator": "rgb(82,82,94)",
       "appmenu_update_icon_color": "#54FFBD",
       "appmenu_warning_icon_color": "#FFBD4F",
       "appmenu_info_icon_color": "#80EBFF",
       "tab_icon_overlay_stroke": "rgb(66,65,77)",