Bug 1370681. WebRender: Remove unnecessary sync messages. r=kats,dvander
authorJeff Muizelaar <jmuizelaar@mozilla.com>
Wed, 07 Jun 2017 09:54:42 -0400
changeset 411262 9363eda05c395837a8c98a366e591ea33a5af240
parent 411261 296f060687f72d68ccfa304a750478937e28f745
child 411263 3fea90e94f1df641f540a3b62e42e171f9b9ee39
push id7391
push usermtabara@mozilla.com
push dateMon, 12 Jun 2017 13:08:53 +0000
treeherdermozilla-beta@2191d7f87e2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskats, dvander
bugs1370681
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1370681. WebRender: Remove unnecessary sync messages. r=kats,dvander These don't need to be sync and we're spending a noticeable amount of time in DeleteImage.
gfx/layers/ipc/PWebRenderBridge.ipdl
ipc/ipdl/sync-messages.ini
--- a/gfx/layers/ipc/PWebRenderBridge.ipdl
+++ b/gfx/layers/ipc/PWebRenderBridge.ipdl
@@ -38,23 +38,23 @@ parent:
   async ReleaseCompositable(CompositableHandle compositable);
 
   // Creates a set of mappings between TextureReadLocks and an associated
   // ReadLockHandle that can be used in Update, and persist until the
   // next Update call.
   async InitReadLocks(ReadLockInit[] locks);
 
   sync Create(IntSize aSize);
-  sync AddImage(ImageKey aImageKey, IntSize aSize, uint32_t aStride,
-                SurfaceFormat aFormat, ByteBuffer aBytes);
+  async AddImage(ImageKey aImageKey, IntSize aSize, uint32_t aStride,
+                 SurfaceFormat aFormat, ByteBuffer aBytes);
   async AddBlobImage(ImageKey aImageKey, IntSize aSize, uint32_t aStride,
                      SurfaceFormat aFormat, ByteBuffer aBytes);
-  sync UpdateImage(ImageKey aImageKey, IntSize aSize,
+  async UpdateImage(ImageKey aImageKey, IntSize aSize,
                    SurfaceFormat aFormat, ByteBuffer aBytes);
-  sync DeleteImage(ImageKey aImageKey);
+  async DeleteImage(ImageKey aImageKey);
   async DeleteCompositorAnimations(uint64_t[] aIds);
   async AddRawFont(FontKey aFontKey, ByteBuffer aBytes, uint32_t aFontIndex);
   async DeleteFont(FontKey aFontKey);
   async DPBegin(IntSize aSize);
   async DPEnd(IntSize aSize, WebRenderParentCommand[] commands, OpDestroy[] toDestroy, uint64_t fwdTransactionId, uint64_t transactionId,
               WrSize aContentSize, ByteBuffer aDL, WrBuiltDisplayListDescriptor aDLDesc,
               WebRenderScrollData aScrollData);
   sync DPSyncEnd(IntSize aSize, WebRenderParentCommand[] commands, OpDestroy[] toDestroy, uint64_t fwdTransactionId, uint64_t transactionId,
--- a/ipc/ipdl/sync-messages.ini
+++ b/ipc/ipdl/sync-messages.ini
@@ -1029,22 +1029,16 @@ description = bug 1350634
 [PUiCompositorController::Pause]
 description =
 [PUiCompositorController::Resume]
 description =
 [PUiCompositorController::ResumeAndResize]
 description =
 [PWebRenderBridge::Create]
 description =
-[PWebRenderBridge::AddImage]
-description =
-[PWebRenderBridge::UpdateImage]
-description =
-[PWebRenderBridge::DeleteImage]
-description =
 [PWebRenderBridge::DPSyncEnd]
 description =
 [PWebRenderBridge::DPGetSnapshot]
 description =
 [PWebRenderBridge::SetAsyncScrollOffset]
 description = test only
 [PWebRenderBridge::SetAsyncZoom]
 description = test only